journald event logging #2850
Merged
journald event logging #2850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
approved
baude
force-pushed
the
eventsjournald
branch
2 times, most recently
from
1ea235e to
40047f9
Compare
openshift-ci-robot
added
size/XXL
rhatdan
reviewed
Apr 4, 2019
baude
force-pushed
the
eventsjournald
branch
11 times, most recently
from
3efd98a to
3493894
Compare
Member
Author
|
/test images |
1 similar comment
Member
Author
|
/test images |
mheon
reviewed
Apr 9, 2019
mheon
reviewed
Apr 9, 2019
libpod/events.go
Outdated
Member
There was a problem hiding this comment.
Why run this every time? We can store it in the runtime (c.runtime.eventer)
Member
There was a problem hiding this comment.
We initialize once during NewRuntime, and after that we can use c.runtime.eventer.Write()
mheon
reviewed
Apr 9, 2019
mheon
reviewed
Apr 9, 2019
mheon
reviewed
Apr 9, 2019
mheon
reviewed
Apr 9, 2019
mheon
reviewed
Apr 9, 2019
Member
Author
|
/test images |
baude
force-pushed
the
eventsjournald
branch
6 times, most recently
from
17264e0 to
d1ca2cf
Compare
Collaborator
|
☔ The latest upstream changes (presumably #2948) made this pull request unmergeable. Please resolve the merge conflicts. |
Member
Author
|
ping folks to review or merge this |
Member
|
I will wait for @mheon OK. |
mheon
reviewed
Apr 24, 2019
Member
|
I got one small thing, LGTM once that's fixed |
add the ability for podman to read and write events to journald instead of just a logfile. This can be controlled in libpod.conf with the `events_logger` attribute of `journald` or `file`. The default will be set to `journald`. Signed-off-by: baude <[email protected]>
Member
Author
|
fixed |
Member
|
LGTM, Lets merge when it passes tests. |
Member
|
Agree |
Member
|
LGTM assuming happy tests |
Member
|
/lgtm |
This was referenced Apr 25, 2019
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add the ability for podman to read and write events to journald instead
of just a logfile. This can be controlled in libpod.conf with the
events_loggerattribute ofjournaldorfile. The default will beset to
journald.Signed-off-by: baude [email protected]