Skip to content

Vendor Buildah 1.7.2 #2802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Mar 29, 2019
Merged

Vendor Buildah 1.7.2 #2802

openshift-merge-robot merged 1 commit into from
Mar 29, 2019

Conversation

@TomSweeneyRedHat
Copy link
Member

@TomSweeneyRedHat TomSweeneyRedHat commented Mar 29, 2019

Signed-off-by: TomSweeneyRedHat tsweeney@redhat.com

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Mar 29, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TomSweeneyRedHat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS labels Mar 29, 2019
@mheon
Copy link
Member

mheon commented Mar 29, 2019

@TomSweeneyRedHat whitespace errors

@TomSweeneyRedHat
Copy link
Member Author

TomSweeneyRedHat commented Mar 29, 2019

##@$)(@#U$)(U whitespace

@TomSweeneyRedHat
Vendor Buildah 1.7.2
1a0d4f2 
Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
@TomSweeneyRedHat
Copy link
Member Author

TomSweeneyRedHat commented Mar 29, 2019

@mheon, repushed, the buildah line in vendor.conf had a trailing blankety-blank blank space. Thanks for the heads up.

@mheon
Copy link
Member

mheon commented Mar 29, 2019

LGTM
@baude @rhatdan @giuseppe @vrothberg Someone care to merge?

@baude
Copy link
Member

baude commented Mar 29, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 29, 2019
@openshift-merge-robot openshift-merge-robot merged commit c5ccab2 into containers:master Mar 29, 2019
@rh-atomic-bot rh-atomic-bot mentioned this pull request Mar 29, 2019
Closed
@TomSweeneyRedHat TomSweeneyRedHat deleted the dev/tsweeney/buildah1.7.2 branch April 14, 2019 17:54
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mheon mheon Awaiting requested review from mheon

@umohnani8 umohnani8 Awaiting requested review from umohnani8

Assignees

@baude baude

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@TomSweeneyRedHat @openshift-ci-robot @mheon @baude @openshift-merge-robot