Remove ulele/deepcopier in favor of JSON deep copy #2760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mheon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
approved
Member
|
LGTM |
Member
|
All kinds of test unhappiness @mheon |
Member
Author
|
It's our good old friend |
Member
Author
|
Fixed by replacing a |
cmd/podman/ps.go
Outdated
| @@ -647,7 +646,7 @@ func printFormat(format string, containers []shared.PsContainerOutput) error { | |||
| } | |||
|
|
|||
| func dumpJSON(containers []shared.PsContainerOutput) error { | |||
| b, err := json.MarshalIndent(containers, "", "\t") | |||
| b, err := json.MarshalIndent(containers, "", " ") | |||
Member
|
Changes LGTM, tests are getting a lot closer, but still not all in yet. |
mheon
force-pushed
the
misc_small_changes
branch
from
7b8d2e2 to
a691d12
Compare
We have a very high performance JSON library that doesn't need to perform code generation. Let's use it instead of our questionably performant, reflection-dependent deep copy library. Most changes because some functions can now return errors. Also converts cmd/podman to use jsoniter, instead of pkg/json, for increased performance. Signed-off-by: Matthew Heon <[email protected]>
Signed-off-by: Matthew Heon <[email protected]>
The jsoniterator library believes that panic() is a reasonable response to being told to indent JSON with a tab. So use spaces instead. Signed-off-by: Matthew Heon <[email protected]>
mheon
force-pushed
the
misc_small_changes
branch
from
a691d12 to
179a66f
Compare
Member
Author
|
Rebased, CI should be happy now |
Member
|
/lgtm |
mheon
added
lgtm
This was referenced Mar 28, 2019
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a very high performance JSON library that doesn't need to perform code generation. Let's use it instead of our questionably performant, reflection-dependent deep copy library.
Most changes because some functions can now return errors.
Also converts cmd/podman to use jsoniter, instead of pkg/json, for increased performance.