-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Add AppArmor key to quadlet containers #27420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add AppArmor key to quadlet containers #27420
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. Small nit
|
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
|
You need to run |
|
Test failures are fixed on main - please rebase and we should be good to merge |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: givensuman, mheon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash all commits into one given it a proper commit message and add Fixes: #27095 to the commit message body please.
|
CI failures are unrelated to this PR and fixed on main; please rebase, and that should clear things for merge. |
4958b46 to
4abc875
Compare
|
@givensuman please squash (fixup) the commits into one as mentioned in #27420 (review), we like a proper git history with useful commit messages. If you don't know how to squash and rebase I am happy to do it or give you instructions on how to. |
Fixes: containers#27095 Signed-off-by: givensuman <[email protected]>
08572f1 to
e7b50c3
Compare
Lemme know if that did the trick! |
This addresses #27095 by adding an AppArmor key to
.containerquadlet files.Checklist
Ensure you have completed the following checklist for your pull request to be reviewed:
commits. (
git commit -s). (If needed, usegit commit -s --amend). The author email must matchthe sign-off email address. See CONTRIBUTING.md
for more information.
Fixes: #00000in commit message (if applicable)make validatepr(format/lint checks)Noneif no user-facing changes)Does this PR introduce a user-facing change?