Skip to content

Conversation

@givensuman
Copy link
Contributor

@givensuman givensuman commented Oct 31, 2025

This addresses #27095 by adding an AppArmor key to .container quadlet files.

Checklist

Ensure you have completed the following checklist for your pull request to be reviewed:

  • [ x ] Certify you wrote the patch or otherwise have the right to pass it on as an open-source patch by signing all
    commits. (git commit -s). (If needed, use git commit -s --amend). The author email must match
    the sign-off email address. See CONTRIBUTING.md
    for more information.
  • [ x ] Referenced issues using Fixes: #00000 in commit message (if applicable)
  • [ x ] Tests have been added/updated (or no tests are needed)
  • [ x ] Documentation has been updated (or no documentation changes are needed)
  • [ x ] All commits pass make validatepr (format/lint checks)
  • [ x ] Release note entered in the section below (or None if no user-facing changes)

Does this PR introduce a user-facing change?

Add AppArmor key to quadlet `.container` files which equates to `--security-opt apparmor=` flag.

Copy link
Contributor

@ygalblum ygalblum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Small nit

@packit-as-a-service
Copy link

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

@ygalblum
Copy link
Contributor

You need to run gofmt

@mheon
Copy link
Member

mheon commented Nov 3, 2025

Test failures are fixed on main - please rebase and we should be good to merge

@mheon
Copy link
Member

mheon commented Nov 3, 2025

/approve
LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: givensuman, mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2025
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash all commits into one given it a proper commit message and add Fixes: #27095 to the commit message body please.

@mheon
Copy link
Member

mheon commented Nov 4, 2025

CI failures are unrelated to this PR and fixed on main; please rebase, and that should clear things for merge.

@github-actions github-actions bot added machine kind/api-change Change to remote API; merits scrutiny labels Nov 5, 2025
@givensuman givensuman force-pushed the T-27095-add-apparmor-quadlet-key branch from 4958b46 to 4abc875 Compare November 5, 2025 16:59
@Luap99
Copy link
Member

Luap99 commented Nov 5, 2025

@givensuman please squash (fixup) the commits into one as mentioned in #27420 (review), we like a proper git history with useful commit messages.
And as @mheon mentioned you will need to rebase as well on main to make the CI happy.

If you don't know how to squash and rebase I am happy to do it or give you instructions on how to.

@givensuman givensuman force-pushed the T-27095-add-apparmor-quadlet-key branch from 08572f1 to e7b50c3 Compare November 5, 2025 23:16
@givensuman
Copy link
Contributor Author

@givensuman please squash (fixup) the commits into one as mentioned in #27420 (review), we like a proper git history with useful commit messages. And as @mheon mentioned you will need to rebase as well on main to make the CI happy.

If you don't know how to squash and rebase I am happy to do it or give you instructions on how to.

Lemme know if that did the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/api-change Change to remote API; merits scrutiny machine release-note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants