Makefile: Drop unused CONTAINER_RUNTIME #27418
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This variable is dead code as far as I can tell. I think it got cargo culted from something similar in skopeo, where it *is* used: https://github.com/containers/skopeo/blob/85598438ce295fc9acdc27a1d5f97b7501f411a5/Makefile#L75 etc. (Instead it looks like there's a `PODMANCMD` here) But I'm effectively using this PR as a way to suggest aligning with what we're doing in bootc, where we have a core principle that `Makefile` should *never* itself spawn containers (or VMs etc). All the rules in Makefile are things that should work when e.g. building RPMs or debs or the like. Those tasks are things that are done via `Justfile`: https://github.com/bootc-dev/bootc/blob/main/Justfile So for example to align, we'd add a `Justfile` here and then `make validatepr` would move to `just validatepr`. Signed-off-by: Colin Walters <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cgwalters The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cgwalters
changed the title
|
Also xref bootc-dev/bootc#1719 |
|
Seems to have been there since the beginning, to avoid the D-word and the swear jar: 9250747 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This variable is dead code as far as I can tell. I think it got cargo culted from something similar in skopeo, where it is used:
https://github.com/containers/skopeo/blob/85598438ce295fc9acdc27a1d5f97b7501f411a5/Makefile#L75 etc.
(Instead it looks like there's a
PODMANCMDhere)But I'm effectively using this PR as a way to suggest aligning with what we're doing in bootc, where we have a core principle that
Makefileshould never itself spawn containers (or VMs etc). All the rules in Makefile are things that should work when e.g. building RPMs or debs or the like.Those tasks are things that are done via
Justfile: https://github.com/bootc-dev/bootc/blob/main/JustfileSo for example to align, we'd add a
Justfilehere and thenmake validateprwould move tojust validatepr.