Skip to content

WIP: fix podman pod rm -a race #2737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cevich wants to merge 8 commits into from
Closed

WIP: fix podman pod rm -a race #2737

cevich wants to merge 8 commits into from

Conversation

@cevich
Copy link
Member

@cevich cevich commented Mar 21, 2019

fixes #2733

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Mar 21, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cevich
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: tomsweeneyredhat

If they are not already assigned, you can assign the PR to them by writing /assign @tomsweeneyredhat in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mheon
Copy link
Member

mheon commented Mar 21, 2019

Wait why is all of cirrus.yml gone? Is this WIP?

@cevich
Copy link
Member Author

cevich commented Mar 21, 2019

@mheon lol...because I'm cheating: Look at the commit title: DO NOT MERGE: FOCUSED TESTING. It's temporary.

I know which cirrus task and script reproduces the problem, so it's MUCH faster if I remove everything else. There's probably a more elegant way to do this, but I know this way works 😀

@mheon
Copy link
Member

mheon commented Mar 21, 2019

@cevich Can we tag these [WIP] in the title? It makes sure the mergebot doesn't cause accidents

@cevich cevich changed the title fix podman pod rm -a race WIP: fix podman pod rm -a race Mar 21, 2019
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 21, 2019
@cevich
Copy link
Member Author

cevich commented Mar 21, 2019

@mheon oh ya, absolutely. Good idea.

@rh-atomic-bot
Copy link
Collaborator

rh-atomic-bot commented Mar 27, 2019

☔ The latest upstream changes (presumably #2648) made this pull request unmergeable. Please resolve the merge conflicts.

@cevich
Copy link
Member Author

cevich commented Mar 27, 2019

Latest example: https://cirrus-ci.com/task/5826816450232320

@cevich cevich force-pushed the fix_pod_rm_test branch 10 times, most recently from 3722970 to 74ed378 Compare April 1, 2019 14:38
cevich added 4 commits April 1, 2019 11:55
@cevich
fix podman pod rm -a race
61b41c0 
Signed-off-by: Chris Evich <cevich@redhat.com>
@cevich
fixup! fix podman pod rm -a race
e0c1b85
@cevich
fixup! fix podman pod rm -a race
1d621ed
@cevich
fixup! fix podman pod rm -a race
02fe974 
Signed-off-by: Chris Evich <cevich@redhat.com>
cevich added 3 commits April 1, 2019 11:55
@cevich
fixup! fix podman pod rm -a race
ed96e27 
Signed-off-by: Chris Evich <cevich@redhat.com>
@cevich
fixup! fix podman pod rm -a race
808bfcf 
Signed-off-by: Chris Evich <cevich@redhat.com>
@cevich
DO NOT MERGE: FOCUSED TESTING
738abc2 
Signed-off-by: Chris Evich <cevich@redhat.com>
@cevich cevich force-pushed the fix_pod_rm_test branch 5 times, most recently from fff7506 to 6c1c25f Compare April 2, 2019 14:02
@cevich
fixup! fix podman pod rm -a race
efe52b3 
Signed-off-by: Chris Evich <cevich@redhat.com>
@cevich cevich force-pushed the fix_pod_rm_test branch from 6c1c25f to efe52b3 Compare April 2, 2019 16:21
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Apr 2, 2019

@cevich: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/validate efe52b3 link /test validate

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cevich cevich mentioned this pull request Apr 2, 2019
Closed
@cevich
Copy link
Member Author

cevich commented Apr 3, 2019

Closing in favor of proper fix: #2706

@cevich cevich closed this Apr 3, 2019
@cevich cevich deleted the fix_pod_rm_test branch June 30, 2021 18:11
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@rhatdan rhatdan Awaiting requested review from rhatdan

@vrothberg vrothberg Awaiting requested review from vrothberg

Assignees

No one assigned

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test-race: podman pod rm -a doesn't remove a running container

4 participants

@cevich @openshift-ci-robot @mheon @rh-atomic-bot