Add libpod journald logging

[haircommander]

Signed-off-by: Peter Hunt [email protected]

[haircommander]

(ignore this for now folks, starting this by seeing if updating CRI-O breaks CI)

[rh-atomic-bot]

☔ The latest upstream changes (presumably #2833) made this pull request unmergeable. Please resolve the merge conflicts.

[rhatdan]

@haircommander Needs rebase.

[haircommander]

@rhatdan needs much more than that :) thanks for the heads up

[haircommander]

Alrighty team, the last of the changes I wanted are in.
--log-driver journald is now supported, as well as podman logs with a container that runs a journald logger.
Also added tests :)

The one thing that is missing is podman logs --follow, but given the sdjournal package API, it'll be kind of annoying to translate that for what we have, so I've opted to disable it and document doing so.

The one thing I'd like to wait for is bumping conmon version to 0.2.0 and make sure it's documented users should have that version to ensure they can actually use this feature. In the meantime, PTAL

@baude @mheon @vrothberg @rhatdan @jwhonce

[mheon]

/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [mheon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rh-atomic-bot]

☔ The latest upstream changes (presumably #3190) made this pull request unmergeable. Please resolve the merge conflicts.

[haircommander]

last remaining issue: containers/conmon#34
which is only an issue when -t --log-driver journald

[rhatdan]

Is this comment still valid

[haircommander]

It will no longer be once i finish conmon exec :)

[rhatdan]

LGTM

[haircommander]

@mheon @baude PTAL--I think the --follow -t issues should come in a follow up, they require some changes in conmon

[mheon]

@haircommander What do we think about json-file? Are we going to keep aliasing this to the Kube logs indefinitely?

[mheon]

I'm willing to let this into 1.4.0, as it's pretty self contained

[haircommander]

@mheon json-file is in my list of things to do--needs addition in conmon first and it isn't high on my priority list. in other words: it'll be an alias until I get to fixing it :)

[haircommander]

containers/conmon#37 here's a tracker--I can file an issue here if you'd like it

[mheon]

Can we throw a not-implemented error instead? I'd prefer to not establish an alias now and break it later

[haircommander]

@mheon Actually, it's not an alias

$ ./bin/podman run --log-driver json-file alpine ls
[conmon:e]: No such log driver json-file
Error: exit status 1

[haircommander]

though, would you prefer if I moved the error higher up the stack? It'll be caught in conmon but may be better not to waste time pretending it'll work in podman

[mheon]

Alright, LGTM then

[mheon]

Eh, I think we're ok with asking Conmon nicely... no changes on our end when it is implemented
/lgtm