Skip to content

Conversation

@TomSweeneyRedHat
Copy link
Member

Signed-off-by: TomSweeneyRedHat [email protected]

The package containernetworking-cni is required, but was not listed in our install.md file. It was already included in our tutorial.

@mheon
Copy link
Member

mheon commented Jan 26, 2018

Is there a containernetworking-cni package on Debian derivatives? I don't see one on my Debian VM

@TomSweeneyRedHat
Copy link
Member Author

bot, retest this please

@TomSweeneyRedHat
Copy link
Member Author

Red Hat CI failure due to repo funkiness.

@baude
Copy link
Member

baude commented Jan 27, 2018

one thing is we actually require cni >= 0.6 which isnt in the centos repos ...

@baude
Copy link
Member

baude commented Jan 27, 2018

bot, restest this please

@rh-atomic-bot
Copy link
Collaborator

☔ The latest upstream changes (presumably 3aa63b2) made this pull request unmergeable. Please resolve the merge conflicts.

@mheon
Copy link
Member

mheon commented Jan 27, 2018

I think we need build-from-source instructions for Debian derivatives and Cent.

@baude
Copy link
Member

baude commented Jan 27, 2018

my ginkgo PR does build from source fwiw

@TomSweeneyRedHat
Copy link
Member Author

Ok, I'm just going to back out the change for Debian/Centos for now and will just leave the Fedora change in play.

@mheon
Copy link
Member

mheon commented Jan 27, 2018

Once we get a PPA up for ubuntu, we can throw a packaged version of CNI in there, which will keep instructions roughly the same.

@mheon
Copy link
Member

mheon commented Jan 28, 2018

bot, retest this please

@rhatdan
Copy link
Member

rhatdan commented Jan 28, 2018

LGTM

@rhatdan rhatdan merged commit cc5a6a3 into containers:master Jan 28, 2018
@TomSweeneyRedHat TomSweeneyRedHat deleted the dev/tsweeney/installfix branch February 9, 2018 18:46
wking added a commit to wking/libpod that referenced this pull request Jun 27, 2018
Catching up with opencontainers/runtime-tools@84a62c6a (generate: Move
Generator.spec to Generator.Config, 2016-11-06, containers#266, v0.6.0), now
that we've bumped runtime-tools in f6c0fc1 (Vendor in latest
runtime-tools, 2018-06-26, containers#1007).

Signed-off-by: W. Trevor King <[email protected]>
rh-atomic-bot pushed a commit that referenced this pull request Jun 27, 2018
Catching up with opencontainers/runtime-tools@84a62c6a (generate: Move
Generator.spec to Generator.Config, 2016-11-06, #266, v0.6.0), now
that we've bumped runtime-tools in f6c0fc1 (Vendor in latest
runtime-tools, 2018-06-26, #1007).

Signed-off-by: W. Trevor King <[email protected]>

Closes: #1008
Approved by: mheon
baude pushed a commit to baude/podman that referenced this pull request Aug 31, 2019
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants