Set blob cache directory based on GraphDriver #2635
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
approved
cmd/podman/pull.go
Outdated
| @@ -127,7 +126,7 @@ func pullCmd(c *cliconfig.PullValues) error { | |||
| } else { | |||
| authfile := getAuthFile(c.String("authfile")) | |||
| spec := image | |||
| systemContext := common.GetSystemContext("", authfile, false) | |||
| systemContext := image2.GetSystemContext("", authfile, false) | |||
There was a problem hiding this comment.
Not due to this review, but I think we can drop image2 now, I think the other include ending in image has gone away. (Or maybe I've been staring at the screen too long today and missed it).
There was a problem hiding this comment.
image2 is used because they have a variable named image in use.
|
LGTM once tests go green |
|
there are some merge commits in the PR from origin/master. Could it be rebased on top of master instead? |
|
@giuseppe Should be fixed now. |
|
LGTM assuming happy tests and a @mheon head nod. |
|
Whole bunch of wierd flakes here |
|
I think the F28 rootless issues might not be flakes. The Ubuntu flake is #2645 |
|
☔ The latest upstream changes (presumably #2696) made this pull request unmergeable. Please resolve the merge conflicts. |
|
☔ The latest upstream changes (presumably #2789) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@rhatdan Rebase please |
Currently in rootless containers, we end up not using the blob cache. We also don't store the blob cache based on the users specified graph storage. This change will cause the cache directory to be stored with the rest of the containe images. While doing this patch, I found that we had duplicated GetSystemContext in two places in libpod. I cleaned this up. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Remove references to image2 in source code. Makes the code slightly more readable. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
7 participants
Currently in rootless containers, we end up not using the blob cache.
We also don't store the blob cache based on the users specified graph
storage. This change will cause the cache directory to be stored with
the rest of the containe images.
While doing this patch, I found that we had duplicated GetSystemContext in
two places in libpod. I cleaned this up.
Signed-off-by: Daniel J Walsh dwalsh@redhat.com