Skip to content

fix macos compile issue with go 1.24.3#26137

Merged
openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom
Luap99:purego
May 14, 2025
Merged

fix macos compile issue with go 1.24.3#26137
openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom
Luap99:purego

Conversation

@Luap99
Copy link
Copy Markdown
Member

@Luap99 Luap99 commented May 14, 2025

Some changes in go broke purego and that causes a compile error on macos. This update fixes it.

Does this PR introduce a user-facing change?

Fixed a compile error on macos with go 1.24.3.

@Luap99
fix macos compile issue with go 1.24.3
db65baa 
Some changes in go broke purego and that causes a compile error on
macos. This update fixes it.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented May 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2025
@ashley-cui
Copy link
Copy Markdown
Member

ashley-cui commented May 14, 2025

LGTM, tested manually with go version go1.24.3 darwin/arm64

@ashley-cui
Copy link
Copy Markdown
Member

ashley-cui commented May 14, 2025

/cherry-pick v5.5

@openshift-cherrypick-robot
Copy link
Copy Markdown
Collaborator

openshift-cherrypick-robot commented May 14, 2025

@ashley-cui: once the present PR merges, I will cherry-pick it on top of v5.5 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick v5.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mheon
Copy link
Copy Markdown
Member

mheon commented May 14, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 571a2e4 into containers:main May 14, 2025
83 checks passed
@openshift-cherrypick-robot
Copy link
Copy Markdown
Collaborator

openshift-cherrypick-robot commented May 14, 2025

@ashley-cui: new pull request created: #26138

Details

In response to this:

/cherry-pick v5.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 14, 2025
Merged
@Luap99 Luap99 deleted the purego branch May 14, 2025 18:03
@chenrui333 chenrui333 mentioned this pull request May 15, 2025
Merged
1 task
@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Aug 13, 2025
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Aug 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@mheon mheon

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Luap99 @ashley-cui @openshift-cherrypick-robot @mheon