Skip to content

Fix pod create failure #2545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Mar 6, 2019
Merged

Fix pod create failure #2545

openshift-merge-robot merged 1 commit into from
Mar 6, 2019

Conversation

@haircommander
Copy link
Collaborator

@haircommander haircommander commented Mar 5, 2019

Before, a pod create would fail if it was set to share no namespaces, but had an infra container. While inefficient (you add a container for no reason), it shouldn't be a fatal failure. Fix this by only failing if the pod was set to share namespaces, but had no infra container.

Signed-off-by: Peter Hunt [email protected]

@haircommander
Copy link
Collaborator Author

haircommander commented Mar 5, 2019

caught from #2504 , where doing
podman pod create --share ""
failed with a pretty unhelpful error

@haircommander
Copy link
Collaborator Author

haircommander commented Mar 5, 2019

Seems to be something I introduced as an intern, whoops haha

mheon
mheon reviewed Mar 5, 2019
View reviewed changes
@mheon
Copy link
Member

mheon commented Mar 5, 2019

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2019
@mheon mheon added Release Notes 1.2.0 and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 5, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2019
@TomSweeneyRedHat
Copy link
Member

TomSweeneyRedHat commented Mar 5, 2019

@haircommander new hire rule #243 "never trust an intern". That should have been covered in NHO . ;^)

@haircommander
Copy link
Collaborator Author

haircommander commented Mar 5, 2019

@TomSweeneyRedHat that's on y'all for merging my PRs :)

@TomSweeneyRedHat
Copy link
Member

TomSweeneyRedHat commented Mar 5, 2019

LGTM, assuming happy tests

@mheon
Copy link
Member

mheon commented Mar 5, 2019

Papr is throwing random internal errors, and not just here

@mheon
Copy link
Member

mheon commented Mar 5, 2019

LGTM

@rhatdan
Copy link
Member

rhatdan commented Mar 5, 2019

bot, retest this please
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 5, 2019
@muayyad-alsadi muayyad-alsadi mentioned this pull request Mar 5, 2019
Closed
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Mar 5, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, haircommander, mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mheon
Copy link
Member

mheon commented Mar 5, 2019

bot, retest this please

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2019
@haircommander
Copy link
Collaborator Author

haircommander commented Mar 6, 2019

/retest

1 similar comment
@haircommander
Copy link
Collaborator Author

haircommander commented Mar 6, 2019

/retest

@haircommander
Fix incorrect pod create failure
b4e184a 
Before, a pod create would fail if it was set to share no namespaces, but had an infra container. While inefficient (you add a container for no reason), it shouldn't be a fatal failure. Fix this by only failing if the pod was set to share namespaces, but had no infra container, and writing a warning if vice versa.

Signed-off-by: Peter Hunt <[email protected]>
@haircommander
Copy link
Collaborator Author

haircommander commented Mar 6, 2019

@rhatdan @mheon @TomSweeneyRedHat lost the lgtm label rebasing off of master to retrigger tests PTAL :)

@mheon
Copy link
Member

mheon commented Mar 6, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2019
@openshift-merge-robot openshift-merge-robot merged commit fb14db4 into containers:master Mar 6, 2019
@haircommander haircommander deleted the weird_pod_bug branch March 6, 2019 19:12
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mheon mheon mheon left review comments

@giuseppe giuseppe giuseppe approved these changes

@vrothberg vrothberg Awaiting requested review from vrothberg

Assignees

@rhatdan rhatdan

@mheon mheon

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@haircommander @mheon @TomSweeneyRedHat @rhatdan @openshift-ci-robot @giuseppe @openshift-merge-robot