Should be defaulting to pull not pull-always

[rhatdan]

Signed-off-by: Daniel J Walsh [email protected]

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rhatdan]

@TomSweeneyRedHat @vrothberg @mheon @baude @giuseppe PTAL

[mheon]

We need to verify that this will pull an updated image if the image is present locally but a newer version of the tag is on the registry

[TomSweeneyRedHat]

Addresses: #2469

[TomSweeneyRedHat]

LGTM assuming happy tests. This fixes the reported issue, I'm just spending a little time seeing if we should get the local image if all of the registries fail. I think we should, but need to poke further.

[TomSweeneyRedHat]

@mheon I pulled an image, updated it by touching /mynewtest.txt, verified the file was present, repulled and then saw the file was no longer there. A little opposite of what you were asking for, bu I think we're covered.

# podman pull docker://quay.io/tomsweeneyredhat/myalpine:latest 
Trying to pull docker://quay.io/tomsweeneyredhat/myalpine:latest...Getting image source signatures
Copying blob 8e3ba11ec2a2 [======================================] 1.4GiB / 1.4GiB
Copying blob a3ed95caeb02 [======================================] 1.4GiB / 1.4GiB
Writing manifest to image destination
Storing signatures
11cd0b38bc3ceb958ffb2f9bd70be3fb317ce7d255c8a4c3f4af30e298aa1aab

# podman images
REPOSITORY                          TAG      IMAGE ID       CREATED        SIZE
quay.io/tomsweeneyredhat/myalpine   latest   11cd0b38bc3c   7 months ago   4.68 MB

# podman run --net=host 11cd0b38bc3c touch /mynewtest.txt
# podman ps -a
CONTAINER ID  IMAGE                                     COMMAND               CREATED         STATUS                     PORTS  NAMES
b7b8dcf0fc5c  quay.io/tomsweeneyredhat/myalpine:latest  touch /mynewtest....  10 seconds ago  Exited (0) 10 seconds ago         condescending_curie

# podman commit b7b8dcf0fc5c quay.io/tomsweeneyredhat/myalpine
Getting image source signatures
Copying blob 73046094a9b8 [======================================] 4.5MiB / 4.5MiB
Copying blob 11f58c859b3a [======================================] 4.0KiB / 4.0KiB
Copying config 75be1a8b36 [======================================] 795b / 795b
Writing manifest to image destination
Storing signatures
75be1a8b36117fdaabc81279966019eba5bf7e19f358b32169551ca75838c474

# podman run quay.io/tomsweeneyredhat/myalpine ls /
bin
dev
etc
home
lib
media
mnt
mynewtest.txt
proc
root
run
sbin
srv
sys
tmp
usr
var

# podman pull docker://quay.io/tomsweeneyredhat/myalpine:latest 
Trying to pull docker://quay.io/tomsweeneyredhat/myalpine:latest...Getting image source signatures
Copying blob 8e3ba11ec2a2 [======================================] 1.4GiB / 1.4GiB
Copying blob a3ed95caeb02 [======================================] 1.4GiB / 1.4GiB
Writing manifest to image destination
Storing signatures
11cd0b38bc3ceb958ffb2f9bd70be3fb317ce7d255c8a4c3f4af30e298aa1aab

# podman images
REPOSITORY                          TAG      IMAGE ID       CREATED          SIZE
<none>                              <none>   75be1a8b3611   33 seconds ago   4.68 MB
quay.io/tomsweeneyredhat/myalpine   latest   11cd0b38bc3c   7 months ago     4.68 MB

# podman run quay.io/tomsweeneyredhat/myalpine ls /
bin
dev
etc
home
lib
media
mnt
proc
root
run
sbin
srv
sys
tmp
usr
var

[TomSweeneyRedHat]

@rhatdan unhappy tests

[mheon]

@TomSweeneyRedHat if it passes your build baseline I'm plenty satisfied

[TomSweeneyRedHat]

@mheon it does indeed pass the baseline with this fix in place.

[mheon]

LGTM then!

[vrothberg]

/lgtm