libpod: change the default rootless cgroup path parent #24301
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rpigott The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
rpigott
force-pushed
the
default-cgoru-path
branch
from
f2345b9
to
cfcb177
Compare
rpigott
changed the title
rpigott
force-pushed
the
default-cgoru-path
branch
from
cfcb177
to
1cb344d
Compare
|
@giuseppe PTAL |
giuseppe
added
the
No New Tests
|
there is no particular reason for using Please adjust all the other occurrences of |
rpigott
force-pushed
the
default-cgoru-path
branch
from
1cb344d
to
01f520b
Compare
|
the changes in containers/common must happen in that repository and later vendor the changes in Podman |
|
IS there be a chance the renaming breaks backwards compatibility with previously created/running containers? |
user.slice is a poor choice of slice name to put containers in. There is no direct conflict with the system user.slice, but it may still be easily confused by humans and isn't descriptive of its purpose. After user.slice, user-$UID.slice, user@$uid.service, we don't need another user.slice if we can avoid it. Let's change user.slice to container.slice to better represent its usage and help disambiguate it from a slew of user cgroups. Signed-off-by: Ronan Pigott <[email protected]>
rpigott
force-pushed
the
default-cgoru-path
branch
from
01f520b
to
e6f3027
Compare
user.slice is a poor choice of slice name to put containers in. There is no direct conflict with the system user.slice, but it may still be easily confused by humans and isn't descriptive of its purpose. After user.slice, user-$UID.slice, user@$uid.service, we don't need another user.slice if we can avoid it.
Let's change user.slice to containers.slice to better represent its usage and help disambiguate it from a slew of user cgroups.
Does this PR introduce a user-facing change?