vendor: update containers/{image,storage} #24054
Conversation
openshift-ci
bot
added
release-note-none
approved
|
Ephemeral COPR build failed. @containers/packit-build please check. |
lsm5
added
the
bloat_approved
giuseppe
force-pushed
the
vendor-image-storage-24-9-2024
branch
from
cb08fc6
to
7c3e2d1
Compare
|
centos-stream 9/10 don't have golang 1.22.6 so this is gonna fail on those envs. Do we need to ship this soon there? If not, then we can ignore centos failures. |
|
@giuseppe validate test is still failing |
giuseppe
force-pushed
the
vendor-image-storage-24-9-2024
branch
from
7c3e2d1
to
05b35ed
Compare
go.mod
Outdated
| go 1.22.0 | ||
| go 1.22.6 | ||
|
|
||
| toolchain go1.22.7 |
There was a problem hiding this comment.
This is wrong, we do not want to force newer toolchains for no reason see the comment above.
There was a problem hiding this comment.
I reverted this part, pushed a new version let's see if it passes the validation...
There was a problem hiding this comment.
You cannot revert the go parts as this is hard enforced by go module now to be the minimum version used for builds. So if any dependency is using this we can either not bump the dep or have to live with that.
What we do control is the toolchain line and for this one we should never use it as the only purpose would be to force a newer version (compared to the go line) to compile with.
There was a problem hiding this comment.
unfortunately that doesn't solve the problem with centos-stream 9/10.
The updated go part is coming from containers/image. I either drop the c/image bump patch or we accept these failures for now.
There was a problem hiding this comment.
Well I brought that up when we did the update to go 1.22, I consider bumping to a z version as minimum fundamentally broken behavior that simply should not happen in a stable language but go decided to allow this so now we are forced to live with that if we want to consume dependencies that just force "random" go updates and yes this means we will be unable to build in slower updating envs. I don't know how much of a problem this will be in practise but I guess if we cannot build on RHEL or even fedora we have a rather big problem.
ref containers/image#2550 (comment)
and we decided in standup that we are ok to bump z versions.
giuseppe
force-pushed
the
vendor-image-storage-24-9-2024
branch
2 times, most recently
from
6a41271
to
dba61ff
Compare
giuseppe
added
the
No New Tests
giuseppe
force-pushed
the
vendor-image-storage-24-9-2024
branch
from
dba61ff
to
71af6ea
Compare
|
Tests are failing |
giuseppe
force-pushed
the
vendor-image-storage-24-9-2024
branch
2 times, most recently
from
c7922f7
to
c17c8f7
Compare
|
Cockpit tests failed for commit c7922f7d0e16189799ab7ef0926832d80a3c0301. @martinpitt, @jelly, @mvollmer please check. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Ephemeral COPR build failed. @containers/packit-build please check. |
Signed-off-by: Giuseppe Scrivano <[email protected]>
Signed-off-by: Giuseppe Scrivano <[email protected]>
giuseppe
force-pushed
the
vendor-image-storage-24-9-2024
branch
from
894be15
to
7f29233
Compare
fixed now |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
LGTM |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
openshift-merge-bot
bot
merged commit 1ae4b04
into
containers:main
The go version there is only go 1.22.5 but we need go 1.22.6 as of containers#24054 It is not clear to me how to best monitor the repos there to see when they get the update. And then there is the fear that podman keeps updating faster then these envs which makes testing there immposible[1] [1] containers/image#2550 (comment) Signed-off-by: Paul Holzinger <[email protected]>
Does this PR introduce a user-facing change?