Add support for Ulimits/Rlimits to kpod create/run #24
Conversation
rhatdan
force-pushed
the
rlimits
branch
2 times, most recently
from
a5dcf44 to
9f9adee
Compare
|
bot retest |
|
☔ The latest upstream changes (presumably #47) made this pull request unmergeable. Please resolve the merge conflicts. |
|
☔ The latest upstream changes (presumably 57599f0) made this pull request unmergeable. Please resolve the merge conflicts. |
rhatdan
changed the title
|
@baude @mheon @umohnani8 PTAL |
cmd/kpod/spec.go
Outdated
There was a problem hiding this comment.
Maybe keep this? Don't think we have OOM adjust in there yet
There was a problem hiding this comment.
I had a patch for this. Seem to have lost it, will add it back for now.
cmd/kpod/spec.go
Outdated
There was a problem hiding this comment.
Is the error we get back from ParseUlimit() useless or should it be included here (errors.Wrapf()?)
|
Two nits, otherwise LGTM pending tests |
|
LGTM |
Signed-off-by: Daniel J Walsh <[email protected]>
|
@rh-atomic-bot r=mheon |
|
📌 Commit a9cf6ea has been approved by |
|
☀️ Test successful - status-papr |
flannel: set the cniVersion on the delegated config
get rest of image tests for pass
github-actions
bot
added
the
locked - please file new issue/PR
4 participants
Signed-off-by: Daniel J Walsh [email protected]