Skip to content

Conversation

@TomSweeneyRedHat
Copy link
Member

Signed-off-by: TomSweeneyRedHat [email protected]

This moves the tutorials down underneath their own page and directory in the docs directory to emulate what we did with Buildah. In addition I slimmed down README.md to make it a quick read for someone wanting to know about the project. The commands took up a lot of space so I've moved them to their own page. We did similar changes with Buildah. The gist is to provide them with high level information on the README,md with the real meat to be found with links from it.

More tutorials are in the works, thus I left the verbiage as plural there. I plan to create another example based on the examples in the podman run man page.

@rhatdan
Copy link
Member

rhatdan commented Jan 16, 2018

@TomSweeneyRedHat You have whitespace errors.

@TomSweeneyRedHat
Copy link
Member Author

@rhatdan thx, think I just nixed them. Empty line at the end of two files.

README.md Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to see this section cleaned up if possible. As of now, it looks like an orphaned list of links.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think I've done so, open to further suggestions. Will repost shortly.

README.md Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have a small description of the tutorial around this? And perhaps in line with the above comment, somehow reformat/reorganize to make it pop a little more

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto previous comment.

@TomSweeneyRedHat
Copy link
Member Author

Going to close/reopen to rekick the tests.

@rhatdan
Copy link
Member

rhatdan commented Jan 18, 2018

@rh-atomic-bot r+

@rh-atomic-bot
Copy link
Collaborator

📌 Commit 0aa2459 has been approved by rhatdan

@rh-atomic-bot
Copy link
Collaborator

⌛ Testing commit 0aa2459 with merge 3b6d208...

@rh-atomic-bot
Copy link
Collaborator

💔 Test failed - status-papr

@TomSweeneyRedHat
Copy link
Member Author

@rhatdan can this be merged? Red Hat CI is still failing, but absolutely no logs/errors to show what's up.

@rhatdan
Copy link
Member

rhatdan commented Jan 18, 2018

Merging since this is a docs change only and cento and travis are fine. Not sure what is broken in the infrastructure.

@rhatdan rhatdan merged commit dd2ba36 into containers:master Jan 18, 2018
@TomSweeneyRedHat TomSweeneyRedHat deleted the dev/tsweeney/readme branch January 18, 2018 20:42
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants