Skip to content

podman-inspect: don't ignore errors #2181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 18, 2019

Conversation

vrothberg
Copy link
Member

Return errors when executing the --format templates. Otherwise,
Podman will just silently ignore them and not print any output
that could guide user into solving the issue.

Fixes: #2159
Signed-off-by: Valentin Rothberg [email protected]

Return errors when executing the --format templates.  Otherwise,
Podman will just silently ignore them and not print any output
that could guide user into solving the issue.

Fixes: containers#2159
Signed-off-by: Valentin Rothberg <[email protected]>
@vrothberg
Copy link
Member Author

This one had a quite educational character. I starred at the format code (and Docker's) for quite a while to eventually find out that the errors were just silently ignored :^)
@baude @rhatdan PTAL.

@rhatdan
Copy link
Member

rhatdan commented Jan 18, 2019

LGTM

1 similar comment
@TomSweeneyRedHat
Copy link
Member

LGTM

@baude
Copy link
Member

baude commented Jan 18, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2019
@baude
Copy link
Member

baude commented Jan 18, 2019

/approved

@rhatdan
Copy link
Member

rhatdan commented Jan 18, 2019

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2019
@openshift-merge-robot openshift-merge-robot merged commit 27de1c1 into containers:master Jan 18, 2019
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants