-
Notifications
You must be signed in to change notification settings - Fork 2.9k
[CI:DOCS] feat: add insecure registry troubleshooting solution #18725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks @fatelei |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is literally issue number four:
Line 95 in c9c5cb2
| ### 4) http: server gave HTTP response to HTTPS client |
edsantiago
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New commit is in the wrong place. It also includes bad data. And, I'm sorry, but it does not parse; needs language fixes. I'll try to make time later today to offer suggestions, but right now this must not merge.
3fca1ad to
b41e33f
Compare
troubleshooting.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion:
For a global workaround: as root[1], create the file `/etc/containers/registries.conf.d/registry-NAME.conf` (replacing NAME with the name of this registry) with the following content:
...
location = "FULLY.QUALIFIED.NAME.OF.REGISTRY"
...
[1] If you are using ...
Reasons:
- make it 100% clear that this is a root action
- give early warning (via footnote) of how to do this on Windows/Mac
- make it clear (still not 100%, but better) that NAME and FULLY.QUALIFIED.NAME are strings that must be replaced by the end user, and not copy-pasted
- there really is no need for a
cd, nor for two steps. It is more understandable as a single file path.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make it simple
Signed-off-by: fatelei <fatelei@gmail.com>
TomSweeneyRedHat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@edsantiago WDYT?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago, fatelei The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM. Thank you for your patience, @fatelei. @containers/podman-maintainers PTAL. |
|
Thanks again @fatelei , very nice work! |
Does this PR introduce a user-facing change?
Just update troubleshooting docs #13039, no other change.