Skip to content

Conversation

@fatelei
Copy link
Contributor

@fatelei fatelei commented May 29, 2023

Does this PR introduce a user-facing change?

Just update troubleshooting docs #13039, no other change.

update troubleshooting for resolving insecure registry.

@rhatdan rhatdan changed the title feat: add insecure registry troubleshooting solution [CI:DOCS] feat: add insecure registry troubleshooting solution May 30, 2023
@rhatdan
Copy link
Member

rhatdan commented May 30, 2023

Thanks @fatelei
@TomSweeneyRedHat @vrothberg PTAL

Copy link
Member

@edsantiago edsantiago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is literally issue number four:

### 4) http: server gave HTTP response to HTTPS client

Copy link
Member

@edsantiago edsantiago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New commit is in the wrong place. It also includes bad data. And, I'm sorry, but it does not parse; needs language fixes. I'll try to make time later today to offer suggestions, but right now this must not merge.

@fatelei fatelei force-pushed the docs branch 2 times, most recently from 3fca1ad to b41e33f Compare June 1, 2023 14:16
Comment on lines 120 to 131
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion:

For a global workaround: as root[1], create the file `/etc/containers/registries.conf.d/registry-NAME.conf` (replacing NAME with the name of this registry) with the following content:
...
location = "FULLY.QUALIFIED.NAME.OF.REGISTRY"
...
 [1] If you are using ...

Reasons:

  • make it 100% clear that this is a root action
  • give early warning (via footnote) of how to do this on Windows/Mac
  • make it clear (still not 100%, but better) that NAME and FULLY.QUALIFIED.NAME are strings that must be replaced by the end user, and not copy-pasted
  • there really is no need for a cd, nor for two steps. It is more understandable as a single file path.

Thank you!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make it simple

Signed-off-by: fatelei <fatelei@gmail.com>
Copy link
Member

@TomSweeneyRedHat TomSweeneyRedHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@edsantiago WDYT?

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago, fatelei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2023
@edsantiago
Copy link
Member

LGTM. Thank you for your patience, @fatelei. @containers/podman-maintainers PTAL.

@TomSweeneyRedHat
Copy link
Member

Thanks again @fatelei , very nice work!
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2023
@openshift-merge-robot openshift-merge-robot merged commit f84a2ff into containers:main Jun 5, 2023
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 4, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants