pod logs enhancements: option to color logs

[kbaran1998]

Created an option to colourise pod logs with an option --color. You can recreate with the following steps:

1. Create a pod with containers

bin/podman pod create --name=pod_testlogs; bin/podman run --name=testlogs_loop1_1 -d --pod=pod_testlogs busybox /bin/sh -c 'for i in `seq 1 10000`; do echo "loop1: $i"; sleep 1; done'; bin/podman run --name=testlogs_loop2_1 -d --pod=pod_testlogs busybox /bin/sh -c 'for i in `seq 1 10000`; do echo "loop2: $i"; sleep 3; done';

2. Logs with colour:

bin/podman pod logs --tail=10 -f --color pod_testlogs

3. Kill all pods and remove containers:

bin/podman kill --all; bin/podman rm --all; bin/podman pod rm --all

Closes #13266

[rhatdan]

remove extra blank lines.

[rhatdan]

remove extra blank lines.

[rhatdan]

Obove the option is --colors?

[Luap99]

Why plural? I think just --color would be even better.

[rhatdan]

SGTM

[giuseppe]

could we make it a string so in future we can extend it if needed?

e.g. GNU diff and ls have --color={never,always,auto} where --color=auto detects if the stdout is a tty before turning on colors.

[Luap99]

We can also extend a bool in the future, it is easy to change it to a string while still keeping the --color only syntax.

[rhatdan]

Just use Colors and option.Colors

[rhatdan]

Please rebase and force push your commit. There should only be one commit.

[rhatdan]

Your PR is still includes many old PRs please rebase and only submit your changes.

[rhatdan]

You need to do something like

git pull origin main
git rebase -i origin
Remove all of the code in the rebase that you did not add and squash all of your commits into a single PR
then do a
git push --force

[kbaran1998]

@rhatdan Whenever I squash only what I added into 1 commit, I get the 884 changes and whenever I rebase, I get back 7 commits...

And if I follow instructions in DCO from the line:
To add your Signed-off-by line to every commit in this branch:

I will get back to 7 commits and 13 changes.

I seem to be going in a loop.

[mheon]

I recommend git fetch to fetch the changes, and then a git rebase upstream/main (where upstream points to this repo, not your fork) to apply your changes on top of latest main

[rhatdan]

Do
git pull upstream main
And then
git rebase -i origin
And see if that clears it up

[rhatdan]

Almost there.

Now cleanup your commit message. removing the excess text.

git commit -a --amend -s
git push --force

Should do it, and then the DCO should pass.

[TomSweeneyRedHat]

nit

Suggested change

	podman container logs --color --names ctrID1 ctrID2
	podman container logs --color --names ctrID1 ctrID2

[kbaran1998]

For some reason, a test in test/e2e/run_test.go called podman run user capabilities test (line 467) is failing on the pipeline and locally, and I am not sure why. Specifically, it is giving me this output:

time="2022-03-28T20:30:41+02:00" level=warning msg="\"/\" is not a shared mount, this could cause issues or missing mounts with rootless containers"
CapBnd: 00000000a80425fb
CapEff: 0000000000000000
CapInh: 0000000000000000
CapBnd: 00000000a80425fb
CapEff: 00000000a80425fb
CapInh: 00000000a80425fb
CapBnd: 00000000a80425fb
CapEff: 00000000a80425fb
CapAmb: 0000000000000002
CapInh: 0000000000000002
CapAmb: 0000000000000000
CapAmb: 0000000000000000
CapInh: 00000000a80425fb
CapAmb: 0000000000000002
CapInh: 0000000000000000

------------------------------
• Failure [17.948 seconds]
Podman run
/usr/local/go/src/github.com/containers/podman/test/e2e/run_test.go:25
  podman run user capabilities test [It]
  /usr/local/go/src/github.com/containers/podman/test/e2e/run_test.go:467

  Expected
      <string>: CapInh: 0000000000000000
  to contain substring
      <string>: 0000000000000002

  /usr/local/go/src/github.com/containers/podman/test/e2e/run_test.go:553
------------------------------
SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSintegration timing results
podman run user capabilities test               17.947786
"unlinkat /tmp/podman/imagecachedir/vfs/dir/2fa52ae883433bc788d7fa1737ca50d2802e0e39d71cae30b4c49378c1207a17/home: permission denied"


Summarizing 1 Failure:

[Fail] Podman run [It] podman run user capabilities test 
/usr/local/go/src/github.com/containers/podman/test/e2e/run_test.go:553

Ran 1 of 114 Specs in 41.103 seconds
FAIL! -- 0 Passed | 1 Failed | 0 Pending | 113 Skipped
--- FAIL: TestLibpod (41.12s)
FAIL
FAIL    command-line-arguments  41.131s
FAIL

I used this command to recreate the error:

GOPATH=~/go go test -v test/e2e/libpod_suite_test.go test/e2e/common_test.go test/e2e/config.go test/e2e/config_amd64.go test/e2e/run_test.go

Would anyone know what could possibly be causing this?

[rhatdan]

You need to rebase your PR.

git pull origin main
git rebase -i origin
git push --force

[TomSweeneyRedHat]

@kbaran1998 you're still fighting DCO issues, looks like two of your commits are unsigned. Please see: https://github.com/containers/podman/pull/13490/checks?check_run_id=5727855035

[TomSweeneyRedHat]

LGTM
and happy green test buttons
Thanks @kbaran1998 !

[rhatdan]

Thanks @kbaran1998
/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kbaran1998, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment