[v3.4] Revert "logs: adjust handling around partial log messages"#11562
Merged
openshift-merge-robot merged 1 commit intocontainers:v3.4from Sep 14, 2021
Merged
[v3.4] Revert "logs: adjust handling around partial log messages"#11562openshift-merge-robot merged 1 commit intocontainers:v3.4from
openshift-merge-robot merged 1 commit intocontainers:v3.4from
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Luap99
changed the title
This reverts commit 21f396d. Changing the log endpoint is a breaking change we should not do in 3.4. [NO TESTS NEEDED] Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Member
|
How is this a breaking change versus a bug fix? |
Member
Author
|
see the discussion here #11263 (comment) |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
Member
|
LGTM |
Member
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 21f396d.
Changing the log endpoint is a breaking change we should not do in 3.4.