utils.RunUnderSystemdScope(): always close Conn

[nalind]

Make sure we close our private connection to the bus, even if we're not successful in in using it to ask systemd to move a unit's processes to a specific control group.

[nalind]

Ran into this while attempting to debug #11263. The symptom is that podman opens connections to the system bus daemon until the system bus daemon determines that it's exceeded the per-UID limit on active connections to the bus daemon (default is 256), and starts refusing new connections from the invoking user (i.e., root). Then podman starts relaying back errors from crun that look like sd-bus call: No buffer space available because crun can't contact the system bus, either.

[vrothberg]

Great catch, LGTM

@Luap99 PTAL

[Luap99]

/lgtm

[Luap99]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99, nalind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [Luap99]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment