Enhance priv. dev. check #11164
Merged
Enhance priv. dev. check #11164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cevich
force-pushed
the
enhance_priv_dev_test
branch
from
2912396 to
3038339
Compare
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cevich, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Member
|
LGTM, but tests are red |
cevich
force-pushed
the
enhance_priv_dev_test
branch
from
3038339 to
85807bf
Compare
Member
|
LGTM |
Member
|
Looks like we have a new flake: |
edsantiago
reviewed
Aug 10, 2021
cevich
force-pushed
the
enhance_priv_dev_test
branch
from
dd50646 to
e70ebe9
Compare
Member
Author
|
(IMHO) This PR is ready for merging if there are no further comments or discovered "woopsie". |
edsantiago
reviewed
Aug 11, 2021
Member
edsantiago
left a comment
edsantiago
left a comment
There was a problem hiding this comment.
It took me a long time to confirm all the changes, and some of the tests are IMO a little incomplete, but that's beyond the scope of this PR. Mostly LGTM aside from one misspelling.
cevich
force-pushed
the
enhance_priv_dev_test
branch
from
e70ebe9 to
be234be
Compare
This test has been failing for a long time but nobody noticed because CI doesn't have the device node (nested-VM support was disabled). After having enabled nested VM support, tests fail due to some unknown special-handling of this device. Fix both problems by removing the `skip()` and switching to a more generic device which is only present when `--privileged` is used. Signed-off-by: Chris Evich <cevich@redhat.com>
Update test to confirm the negative-case, proving the `--privileged` "option is required" for this character device to be present in a container (including rootless). Signed-off-by: Chris Evich <cevich@redhat.com>
The `ls` command is not intended for this purpose and may behave in unexpected ways, leading to false positive or negative results. Update the tests to use the purpose built `test` command instead. Also added several *TODO* comments for possible future testing enhancements. Signed-off-by: Chris Evich <cevich@redhat.com>
cevich
force-pushed
the
enhance_priv_dev_test
branch
from
be234be to
73a755e
Compare
Member
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update test to confirm the negative-case, proving the
--privileged"option is required" case.