-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support dnsConfig in kube yaml with "podman play kube" #9132
Labels
Good First Issue
This issue would be a good issue for a first time contributor to undertake.
In Progress
This issue is actively being worked by the assignee, please do not work on this at this time.
kind/feature
Categorizes issue or PR as related to a new feature.
locked - please file new issue/PR
Assist humans wanting to comment on an old issue or PR with locked comments.
Comments
openshift-ci-robot
added
the
kind/feature
Categorizes issue or PR as related to a new feature.
label
Jan 27, 2021
Should be very easy addition (most changes would be in |
mheon
added
the
Good First Issue
This issue would be a good issue for a first time contributor to undertake.
label
Jan 27, 2021
can you cite the documentation? |
baude
added
the
In Progress
This issue is actively being worked by the assignee, please do not work on this at this time.
label
Jan 28, 2021
@phlogistonjohn if you would like to try out the PR #9150 , you feedback would be welcome |
baude
added a commit
to baude/podman
that referenced
this issue
Jan 29, 2021
when creating kubernetes yaml from containers and pods, we should honor any custom dns settings the user provided. in the case of generate kube, these would be provided by --dns, --dns-search, and --dns-opt. if multiple containers are involved in the generate, the options will be cumulative and unique with the exception of dns-opt. when replaying a kube file that has kubernetes dns information, we now also add that information to the pod creation. the options for dnspolicy is not enabled as there seemed to be no direct correlation between kubernetes and podman. Fixes: containers#9132 Signed-off-by: baude <[email protected]>
mheon
pushed a commit
to mheon/libpod
that referenced
this issue
Feb 4, 2021
when creating kubernetes yaml from containers and pods, we should honor any custom dns settings the user provided. in the case of generate kube, these would be provided by --dns, --dns-search, and --dns-opt. if multiple containers are involved in the generate, the options will be cumulative and unique with the exception of dns-opt. when replaying a kube file that has kubernetes dns information, we now also add that information to the pod creation. the options for dnspolicy is not enabled as there seemed to be no direct correlation between kubernetes and podman. Fixes: containers#9132 Signed-off-by: baude <[email protected]>
github-actions
bot
added
the
locked - please file new issue/PR
Assist humans wanting to comment on an old issue or PR with locked comments.
label
Sep 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Good First Issue
This issue would be a good issue for a first time contributor to undertake.
In Progress
This issue is actively being worked by the assignee, please do not work on this at this time.
kind/feature
Categorizes issue or PR as related to a new feature.
locked - please file new issue/PR
Assist humans wanting to comment on an old issue or PR with locked comments.
Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)
/kind feature
Description
Support "dnsConfig" in pod YAML when running podman play kube.
AFAICT it doesn't show up in a code search at github and only appears in one issue (linked below) so I assume its not implemented yet so I chose feature. :-)
Steps to reproduce the issue:
I have a test set up where I run a specifc DNS server locally but that is not connected to the system resolv.conf. I can use
podman pod create
to establish this DNS server for my test pod.The command
podman generate kube
doesn't reflect these added optionsFollowing the k8s documentation to manaully add "dnsPolicy" and "dnsConfig" subsections does not seem to change the behavior of the containers in the pod.
Describe the results you received:
The dnsConfig subsection appears to be ignored.
Describe the results you expected:
Podman treats the dnsConfig options similarly to the podman pod create options
--dns
,--dns-opt
and--dns-search
Additional information you deem important (e.g. issue happens only occasionally):
I found the following by searching github: #5620 (comment)
From this it was not clear that if these were already supported or simply should be supported in the future.
FWIW I'm running this rootless. But since the
podman pod create
options worked rootless I would assume the kube yaml could apply to either rootless or rootful.Output of
podman version
:Output of
podman info --debug
:Package info (e.g. output of
rpm -q podman
orapt list podman
):Have you tested with the latest version of Podman and have you checked the Podman Troubleshooting Guide?
Yes/No
Additional environment details (AWS, VirtualBox, physical, etc.):
The text was updated successfully, but these errors were encountered: