Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use of constant pkg/network/config.go#CNIConfigDir #6212

Closed
m8nmueller opened this issue May 13, 2020 · 0 comments · Fixed by #6215
Closed

Use of constant pkg/network/config.go#CNIConfigDir #6212

m8nmueller opened this issue May 13, 2020 · 0 comments · Fixed by #6215
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@m8nmueller
Copy link
Contributor

/kind bug

Description

The files pkg/network/files.go and pkg/api/handlers/libpod/networks.go still make use of the static constant CNIConfigDir in pkg/network/config.go.

The resulting issue appears when the cni config dir is changed in libpod.conf. While network create and network ls use pkg/domain/infra/abi/network.go#getCNIConfDir, inspect and remove use pkg/network/files.go#GetCNIConfigPathByName (for inspect indirectly via ReadRawCNIConfByName).

I will fix this by replacing the use of the constant in GetCNIConfigPathByName by a call to getCNIConfDir.
@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label May 13, 2020
@m8nmueller m8nmueller mentioned this issue May 13, 2020
Merged
snj33v pushed a commit to snj33v/libpod that referenced this issue May 31, 2020
@m8nmueller @snj33v
Use the libpod.conf cni_config_dir option for inspect and delete
c2508dd 
The pkg/network/files.go methods currently use the constant '/etc/cni/net.d'
for network handling. This results in the unability of podman-network-inspect
and podman-network-rm to locate the cni network configuration files.
This commit propagates the libpod.Runtime through the networking methods and
finally makes use of its configuration (config.Network.NetworkConfigDir).
Closes containers#6212

Signed-off-by: Maximilian Müller <[email protected]>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use the containers.conf cni_config_dir option for inspect and delete
2 participants
@m8nmueller @openshift-ci-robot