Confirmation prompt for 'container prune' breaks non-interactive use

[StefanBruens]

/kind bug

Description

With podman 1.7.0, it is no longer possible to prune containers from a script.

The prompt can be avoided by adding --force, but this will also prune running containers.

Please add a --yes/-y flag to allow confirmation from a script.

The prompt was added here:
0602ce4

Steps to reproduce the issue:

podman container prune && echo "OK"

Describe the results you received:

WARNING! This will remove all stopped containers.
Are you sure you want to continue? [y/N]

Describe the results you expected:

OK

Output of podman version:

1.7.0

[mheon]

Wait, container prune --force prunes running? That sounds like a bug.

…

On Sat, Jan 11, 2020, 13:49 StefanBruens ***@***.***> wrote: /kind bug *Description* With podman 1.7.0, it is no longer possible to prune containers from a script. The prompt can be avoided by adding --force, but this will also prune running containers. Please add a --yes/-y flag to allow confirmation from a script. *Steps to reproduce the issue:* podman container prune && echo "OK" *Describe the results you received:* WARNING! This will remove all stopped containers. Are you sure you want to continue? [y/N] *Describe the results you expected:* OK *Output of podman version:* 1.7.0 — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#4844>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB3AOCBB6XXY67R6T3UF3MTQ5IICVANCNFSM4KFTNDTQ> .

[StefanBruens]

https://github.com/containers/libpod/blob/master/cmd/podman/containers_prune.go#L43

[mheon]

It's possible the description there may be inaccurate. prune --force should only remove stopped containers, but with no prompt. I need to verify if this is actually the case.

[baude]

@mheon @StefanBruens this just tripped me up as well while i was working on the apiv2 stuff so i had to look at the code as well. it turns out the description is incorrect. the force should only be used to skip the interactive bit. however, it IS passed onto the container removal call. that said, we are safe here because prune uses container filters to select which containers to prune. therefore the force is basically a no-op. i'll see about a quick pr to tidy this up.