Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bash-completion: list files for podman build -f #3878

Closed
vrothberg opened this issue Aug 23, 2019 · 3 comments · Fixed by #5164
Closed

bash-completion: list files for podman build -f #3878

vrothberg opened this issue Aug 23, 2019 · 3 comments · Fixed by #5164
Assignees
@vrothberg
Labels
do-not-close Good First Issue This issue would be a good issue for a first time contributor to undertake. kind/feature Categorizes issue or PR as related to a new feature. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. stale-issue

Comments

@vrothberg
Copy link
Member

/kind feature

podman build -f[TAB] doesn't list files or completes paths. Having that would make it easier to use. Likely, other commands could benefit from that as well but I did not examine that yet.
@openshift-ci-robot openshift-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 23, 2019
@github-actions
Copy link

This issue had no activity for 30 days. In the absence of activity or the "do-not-close" label, the issue will be automatically closed within 7 days.

@rhatdan rhatdan added the Good First Issue This issue would be a good issue for a first time contributor to undertake. label Oct 31, 2019
@rhatdan
Copy link
Member

rhatdan commented Oct 31, 2019

I think we still want to improve bash completions.

@NevilleC NevilleC mentioned this issue Dec 30, 2019
Closed
@rhatdan
Copy link
Member

rhatdan commented Dec 31, 2019

@NevilleC you can have this one.

@NevilleC NevilleC self-assigned this Dec 31, 2019
NevilleC added a commit to NevilleC/libpod that referenced this issue Jan 8, 2020
@NevilleC
Enable bash completion for podman commands
4ce5e0e 
I added a command completion that generates
the bash script that would enable the shell
completion, using the cobra function GenBashCompletion.

Closes containers#3878

Signed-off-by: Neville Cain <[email protected]>
@NevilleC NevilleC removed their assignment Jan 13, 2020
@vrothberg vrothberg self-assigned this Feb 11, 2020
vrothberg added a commit to vrothberg/libpod that referenced this issue Feb 11, 2020
@vrothberg
podman build -f completions
9e1f6ae 
Also cleanup the code a bit. There's no --runtime flag for build.

Fixes: containers#3878
Signed-off-by: Valentin Rothberg <[email protected]>
@vrothberg vrothberg mentioned this issue Feb 11, 2020
Merged
snj33v pushed a commit to snj33v/libpod that referenced this issue May 31, 2020
@vrothberg @snj33v
podman build -f completions
547d12a 
Also cleanup the code a bit. There's no --runtime flag for build.

Fixes: containers#3878
Signed-off-by: Valentin Rothberg <[email protected]>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@vrothberg vrothberg

Labels
do-not-close Good First Issue This issue would be a good issue for a first time contributor to undertake. kind/feature Categorizes issue or PR as related to a new feature. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. stale-issue
Projects
None yet
Milestone
No milestone
4 participants
@rhatdan @vrothberg @NevilleC @openshift-ci-robot