podman exit(0) on pull failure

[cevich]

/kind bug

Description

I have a script that tries to run podman pull docker://some/ting:new and if it fails, runs a podman build then push for the image. The podman pull does fail, but always exits 0 (signaling success).

Steps to reproduce the issue:

1. $ podman pull docker://quay.io/foo/bar:baz
2. $ echo "Exit: $?"

Describe the results you received:

Trying to pull docker://quay.io/foo/bar:baz...Failed
(0x1840f00,0xc00058a820)
Exit: 0

Describe the results you expected:

Trying to pull docker://quay.io/foo/bar:baz...Failed
Exit: 1

Additional information you deem important (e.g. issue happens only occasionally):

Same result running as root (through sudo) or as a user

Output of podman version:

podman version 1.1.2

Output of podman info --debug:

debug:
  compiler: gc
  git commit: a95a49d3038462d033f84ac314ec8a3064a99cff
  go version: go1.11.5
  podman version: 1.1.2
host:
  BuildahVersion: 1.7.1
  Conmon:
    package: podman-1.1.2-1.git0ad9b6b.fc29.x86_64
    path: /usr/libexec/podman/conmon
    version: 'conmon version 1.12.0-dev, commit: a95a49d3038462d033f84ac314ec8a3064a99cff'
  Distribution:
    distribution: fedora
    version: "29"
  MemFree: 205324288
  MemTotal: 12437794816
  OCIRuntime:
    package: runc-1.0.0-83.dev.gitf56b4cb.fc29.x86_64
    path: /usr/bin/runc
    version: |-
      runc version 1.0.0-rc6+dev
      commit: cb19e6a579f2a7da040525d725cfb871b4275148
      spec: 1.0.1-dev
  SwapFree: 1019166720
  SwapTotal: 1073737728
  arch: amd64
  cpus: 4
  hostname: ---cut---
  kernel: 4.20.16-200.fc29.x86_64
  os: linux
  rootless: true
  uptime: 199h 32m 14.82s (Approximately 8.29 days)
insecure registries:
  registries:
  - localhost
registries:
  registries:
  - docker.io
  - registry.fedoraproject.org
store:
  ConfigFile: /home/cevich/.config/containers/storage.conf
  ContainerStore:
    number: 0
  GraphDriverName: overlay
  GraphOptions:
  - overlay.mount_program=/usr/bin/fuse-overlayfs
  GraphRoot: /home/cevich/.local/share/containers/storage
  GraphStatus:
    Backing Filesystem: xfs
    Native Overlay Diff: "false"
    Supports d_type: "true"
    Using metacopy: "false"
  ImageStore:
    number: 1
  RunRoot: /run/user/---cut---
  VolumePath: /home/cevich/.local/share/containers/storage/volumes

[rhatdan]

Podman pull needs a full rewrite similar to what we did for buildah pull.

[TomSweeneyRedHat]

I believe this it the PR with the PULL changes that @rhatdan is referring to: containers/buildah#1319

[giuseppe]

fixed as part of: #2911