Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve podman cli execution for models #1810

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

axel7083
Copy link
Contributor

@axel7083 axel7083 commented Sep 30, 2024

What does this PR do?

Following #1813 the isModelUploaded and deleteRemoteModel are moved inside the ModelManager class, and uses the PodmanConnection, executeSSH method.

Screenshot / video of UI

What issues does this PR fix or reference?

Fixes #1809

How to test this PR?

  • unit tests has been provided

@axel7083
Copy link
Contributor Author

Need rebase when the following will be merged

@axel7083 axel7083 force-pushed the refactor/move-model-utils-logic-podman branch from 963bad8 to 1f0b6f5 Compare October 1, 2024 08:16
@axel7083 axel7083 changed the title feat: improve podman cli execution feat: improve podman cli execution for models Oct 1, 2024
@axel7083 axel7083 marked this pull request as ready for review October 1, 2024 08:19
@axel7083 axel7083 requested review from benoitf, jeffmaury and a team as code owners October 1, 2024 08:19
@axel7083 axel7083 marked this pull request as draft October 7, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ModelUtils.ts should not contain process execution logic
1 participant