Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for environment variable secrets #971

Merged
merged 4 commits into from
Jun 24, 2024

Conversation

mokibit
Copy link
Contributor

@mokibit mokibit commented Jun 24, 2024

Credit for solution of this problem goes to @breca, I added requested unit tests.
PR completes the PR of @breca #856 and solves issue #671.

@mokibit mokibit force-pushed the type-env-secret-support branch from fa5b992 to a36fded Compare June 24, 2024 17:55
@mokibit
Copy link
Contributor Author

mokibit commented Jun 24, 2024

FYI, @p12tic, functionality of get_secret_args() is not fully tested yet.

@mokibit mokibit force-pushed the type-env-secret-support branch from a36fded to 43a1f3f Compare June 24, 2024 18:09
mokibit added 2 commits June 24, 2024 21:24
Signed-off-by: Monika Kairaityte <[email protected]>
Signed-off-by: Monika Kairaityte <[email protected]>
@mokibit mokibit force-pushed the type-env-secret-support branch from 43a1f3f to 405001b Compare June 24, 2024 18:24
@p12tic p12tic merged commit 84f7fdd into containers:main Jun 24, 2024
8 checks passed
@mokibit mokibit deleted the type-env-secret-support branch June 25, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants