Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX issue https://github.com/containers/podman-compose/issues/704 - Windows fix sock not working. #905

Merged
merged 1 commit into from
Apr 7, 2024

Conversation

acotty
Copy link
Contributor

@acotty acotty commented Apr 7, 2024

From issue 704:
Describe the bug
I try to use portainer. On podman-compose up -d - /run/podman/podman.sock:/var/run/docker.sock in docker-compose.yml becomes -v E:\run\podman\podman.sock:/var/run/docker.sock:Z

.....snuip....

Expected behavior

-v \run\podman\podman.sock:/var/run/docker.sock:Z

instead of

Actual behavior

-v E:\run\podman\podman.sock:/var/run/docker.sock:Z

The issue is for portainer, but it also affects all sock on Windows due to the code not being windows aware.

@muayyad-alsadi
Copy link
Collaborator

the problem is that .sock is just a convention.

but it also affects all sock on Windows due to the code not being windows aware.

I would love the code to be OS agnostic as much as possible.

@muayyad-alsadi muayyad-alsadi merged commit 9a5b439 into containers:main Apr 7, 2024
7 of 8 checks passed
@p12tic
Copy link
Collaborator

p12tic commented Apr 8, 2024

@muayyad-alsadi I think this PR should have included a test before being merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants