Support all healthcheck options in Compose #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
recursiveribbons
commented
Sep 24, 2023
recursiveribbons
commented
- Added start_interval to the healthcheck block parser
- Changed the healthcheck flags to the normalized podman flags
recursiveribbons
force-pushed
the
healthcheck
branch
from
ddfb28a to
8510983
Compare
p12tic
requested changes
Mar 8, 2024
recursiveribbons
force-pushed
the
healthcheck
branch
from
8510983 to
ae6e67f
Compare
|
(rebased branch onto main and force pushed) |
recursiveribbons
force-pushed
the
healthcheck
branch
from
338f44b to
34de89f
Compare
Signed-off-by: Robin Syl <[email protected]>
Signed-off-by: Robin Syl <[email protected]>
Signed-off-by: Robin Syl <[email protected]>
recursiveribbons
force-pushed
the
healthcheck
branch
from
34de89f to
efccf15
Compare
|
I'm not sure how to fix the unit test, as |
Signed-off-by: Robin Syl <[email protected]>
recursiveribbons
force-pushed
the
healthcheck
branch
from
65072f7 to
f512566
Compare
|
Do you actually want me to commit the entire formatted podman_compose.py file or just let the test fail? also the pre-commit checks wants me to format 10 files so I'm not sure if I should |
d0b3rm4n
reviewed
Oct 26, 2024
| @@ -1032,12 +1029,12 @@ async def container_to_args(compose, cnt, detached=True): | |||
| podman_args.append("--no-healthcheck") | |||
| elif healthcheck_type == "CMD": | |||
| cmd_q = "' '".join([cmd_quote(i) for i in healthcheck_test]) | |||
| podman_args.extend(["--healthcheck-command", "/bin/sh -c " + cmd_q]) | |||
| podman_args.extend(["--health-cmd", "/bin/sh -c " + cmd_q]) | |||
There was a problem hiding this comment.
I don't think in CMD case this should be executed with /bin/sh prevents cases from working where there is no /bin/sh in the image like minimal images for Rust applications. I don't have docker to verify, but from the documentation, my understanding is that this is ran without shell.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.