-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support podman's external rootfs management #737
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. It looks good in principle.
Unit tests are needed. pytests/test_container_to_args.py
already tests some of the ways to call container_to_args
.
860ccc7
to
ffafaee
Compare
Hi! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
I've now realized that there are two ways to supply podman-specific config keys. This will be addressed in the future in a separate PR.
Rebased. |
Signed-off-by: GnSight <[email protected]>
Signed-off-by: GnSight <[email protected]>
The podman-run command supports external rootfs management by using the --rootfs flag (documentation).
By specifying the --rootfs flag, the first parameter of podman-run will be the path of container's rootfs, instead of the specification of image. This patch makes the compose file parser able to recognize the "rootfs" field, and produce the correct args for podman-run command.