-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding basic support for --profile argument #592
Adding basic support for --profile argument #592
Conversation
Signed-off-by: Dixon Whitmire <[email protected]>
Signed-off-by: Dixon Whitmire <[email protected]>
Signed-off-by: Dixon Whitmire <[email protected]>
Any update on this PR? Is it ready to merge? This would be immensely useful to disable select services, along with compose overrides for different environments (dev, staging, ...). |
@lc-guy - I don't have write access to this repo, but am still available to implement feedback on this PR if that's currently blocking it's acceptance. |
Co-authored-By: Dixon Whitmire <[email protected]> Authored-By: Dixon Whitmire <[email protected]> See: containers#592
Just gonna keep the discussion alive. @dixonwhitmire do I understand correctly that this PR is ready to merge from your side? This feature would be of high value to us so if we can do anything to help move the process along we will gladly do so. |
@Steiniche - Yes, that is correct. I believe that the PR is good to go, and just requires maintainer approval. Thanks! |
really need this feature. |
Any update on a PR regarding the |
@dixonwhitmire Can we get this released, the PR has been merged for a year now... 🥲 (hate to be this guy, sorry) |
Hello @Jmennius ! Unfortunately I am not a maintainer of this repo, and cannot create a release or merge a PR. |
This PR adds support for the global --profile option .
High level updates include:
I limited test case support to the config and up/down commands, since these are the commands I need for my specific use-case.
For my use-case I am using podman-compose as an interim solution while I migrate some of my project local development environments from docker compose to podman/k8s.
Additionally, I tried to align my changes to the current “style” of the repo with focused changes to make diff’ing reviews easier. From an implementation standpoint I focused on specific enablement using the “—profile” argument.
If this PR is accepted, I will do a follow-up PR to support the COMPOSE_PROFILES environment variable. We can also add additional test cases to ensure the “spec” is covered in light of podman-compose’s current support.
Test case output (I can add a marker to skip the up/down tests if needed)
closes #430
Signed-off-by: Dixon Whitmire [email protected]