Exit codes #521
Exit codes #521
Conversation
Signed-off-by: Benjamin Karran <[email protected]>
Signed-off-by: Benjamin Karran <[email protected]>
|
Want to put +1 vote for this, this is really annoying. Here's the example of how it looks like (podman machine is stopped, so it produces error).
|
|
@ebekebe looks like other commands (like |
|
@mi-volodin I didn't notice that other commands also don't work. I would have included them at the time. However, we don't use podman-compose (and podman) anymore, because of how it is maintained. As there is no feedback from a project maintainer yet, I don't want to put any more effort into this. Feel free to make your own PR or add you changes to this PR. Let me know, if you want push access. |
|
sad to see an unmaintainable repo |
|
Seems like the issue fixed by this PR is still present at least for some commands. @ebekebe Would you be open to rebase the PR? |
| @@ -1863,7 +1863,9 @@ def compose_push(compose, args): | |||
| continue | |||
| if services and cnt["_service"] not in services: | |||
| continue | |||
| compose.podman.run([], "push", [cnt["image"]], sleep=0) | |||
| exit_code = compose.podman.run([], "push", [cnt["image"]], sleep=0).wait() | |||
| if (not getattr(args, "ignore_push_failures", None)) and 0 != exit_code: | |||
There was a problem hiding this comment.
Why can't we do args.ignore_push_failures? Seems simplier.
Also, please use exit_code != 0 style.
Failure exit codes for
buildandpushare currently not forwarded as exit code for podman-compose. This makes it impossible to use podman-compose in a scripted environment like CI.With this PR, podman-compose stops building/pushing when the underlying podman command fails and forwards its exit code.