Implement 'image' volume type for services #1336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lautat
force-pushed
the
feature/mount-images-as-volumes
branch
from
a086cbf to
7cc1a80
Compare
lautat
commented
Nov 19, 2025
Comment on lines
468
to
469
| if mount_desc.get("read_only", False): | ||
| opts.append("ro") |
Contributor
Author
There was a problem hiding this comment.
Seems that ro is invalid with type=image. I guess the same might apply to propagation above.
Collaborator
There was a problem hiding this comment.
Maybe it's worth throwing an exception in that case? I'm merging the PR anyway, as it's still an improvement to the current situation.
Contributor
Author
|
I also realised that |
p12tic
approved these changes
Nov 29, 2025
This adds support for volume.type=image in services, as specified in [Compose spec](https://github.com/compose-spec/compose-spec/blob/76d4a3d08f9d4eb251092746394a64327031a6c6/05-services.md#long-syntax-5). Fixes containers#1202 Signed-off-by: Atte Lautanala <[email protected]>
p12tic
force-pushed
the
feature/mount-images-as-volumes
branch
from
7cc1a80 to
37ed118
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for volume.type=image in services, as specified in Compose spec.
Fixes #1202