refactor: clean up redundant proj_name, net vars #1014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legobeat
force-pushed
the
refactor-redundant-vars
branch
from
f13b657 to
80b6170
Compare
legobeat
commented
Jul 31, 2024
|
Looks good overall. We can clean up volume_ls args as well. The project does not use |
- remove unutilized proj_name parameter from volume_ls Signed-off-by: legobt <[email protected]> proj_name
Signed-off-by: legobt <[email protected]>
legobeat
force-pushed
the
refactor-redundant-vars
branch
from
80b6170 to
ed58ac0
Compare
|
@p12tic Thank your the review and feedback! Just rebased and updated accordingly. |
p12tic
approved these changes
Aug 2, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No user-visible changes. Minor refactor cleaning up redundant variable assignments.
Motivation: Make implementation of #1015 cleaner.