Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support podman-compose build --format docker #354

Closed
casabre opened this issue Nov 11, 2021 · 5 comments
Closed

Support podman-compose build --format docker #354

casabre opened this issue Nov 11, 2021 · 5 comments
Labels
enhancement New feature or request

Comments

@casabre
Copy link

casabre commented Nov 11, 2021

Is your feature request related to a problem? Please describe.
I have a docker-compose file which has also some build sections. Some of the Dockerfiles are using SHELL ["/bin/bash", "-c"]. When running podman-compose build, serveral

WARN[0024] SHELL is not supported for OCI image format, [/bin/bash -o pipefail -c] will be ignored. Must use `docker` format

are popping up. See also podman #8477

Describe the solution you'd like
A forwarding of the --format docker flag to any underlying build process. Something like
podman-compose build --format docker could do the job.

Describe alternatives you've considered
None, besides building it manually.

Additional context
None

@casabre casabre added the enhancement New feature or request label Nov 11, 2021
@muayyad-alsadi
Copy link
Collaborator

you can already pass it like this

$ podman-compose --help

--podman-build-args args
                        custom arguments to be passed to `podman build`
$ podman-compose --podman-build-args='--format docker' build

unless you suggest making it passed by default

@rhatdan what do you think?

@casabre
Copy link
Author

casabre commented Nov 13, 2021

@muayyad-alsadi thanks for letting me know. Was not aware of that flag.

But it seems not to work somehow

$ podman-compose --podman-build-args='--format docker' build
usage: podman-compose [-h] [-f FILE] [-p PROJECT_NAME] [--podman-path PODMAN_PATH] [--no-ansi] [--no-cleanup] [--dry-run]
                      [-t {1pod,1podfw,hostnet,cntnet,publishall,identity}]
                      {pull,push,build,up,down,run,start,stop,restart} ...
podman-compose: error: argument command: invalid choice: '--podman-build-args=--format docker' (choose from 'pull', 'push', 'build', 'up', 'down', 'run', 'start', 'stop', 'restart')

Is there a specific version necessary respectively a specific podman version?

@muayyad-alsadi
Copy link
Collaborator

muayyad-alsadi commented Nov 13, 2021 via email

@muayyad-alsadi
Copy link
Collaborator

@casabre you seems to have an older version of podman-compose

@casabre
Copy link
Author

casabre commented Nov 21, 2021

@muayyad-alsadi I installed the pypi.org version which was available at the time raising the issue. I go for an update and thanks for the info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants