Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(helm): Introduce priorityClassName system-node-critical #220

Merged
merged 2 commits into from
Jan 10, 2024
Merged

feat(helm): Introduce priorityClassName system-node-critical #220

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e678245
feat(helm-charts): Introduced priorityClassName system-node-critical …
ffuerste Jan 6, 2024
2483fe9
fix(helm-charts): streamline new value for activating the priority cl…
ffuerste Jan 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions deployment/helm/balloons/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ customize with their own values, along with the default values.
| `hostPort` | 8891 | metrics port to expose on the host |
| `config` | see [helm chart values](tree:/deployment/helm/balloons/values.yaml) for the default configuration | plugin configuration data |
| `nri.patchRuntimeConfig` | false | enable NRI in containerd or CRI-O |
| `nri.setPodPriorityClassNodeCritical` | false | enable [marking Pod as node critical](https://kubernetes.io/docs/tasks/administer-cluster/guaranteed-scheduling-critical-addon-pods/#marking-pod-as-critical) |
ffuerste marked this conversation as resolved.
Show resolved Hide resolved
| `initImage.name` | [ghcr.io/containers/nri-plugins/config-manager](https://ghcr.io/containers/nri-plugins/config-manager) | init container image name |
| `initImage.tag` | unstable | init container image tag |
| `initImage.pullPolicy` | Always | init container image pull policy |
Expand Down
3 changes: 3 additions & 0 deletions deployment/helm/balloons/templates/daemonset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,9 @@ spec:
mountPath: /var/run/nri-resource-policy
- name: nrisockets
mountPath: /var/run/nri
{{- if .Values.nri.setPodPriorityClassNodeCritical }}
priorityClassName: system-node-critical
{{- end }}
volumes:
- name: resource-policydata
hostPath:
Expand Down
4 changes: 4 additions & 0 deletions deployment/helm/balloons/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,10 @@ resources:

nri:
patchRuntimeConfig: false
# NRI plugins should be considered as part of the container runtime.
# Therefore, adding the system-node-critical priority class to the DaemonSet,
# could mitigate potential risk in a running system under load.
setPodPriorityClassNodeCritical: false
klihub marked this conversation as resolved.
Show resolved Hide resolved

initContainerImage:
name: ghcr.io/containers/nri-plugins/nri-config-manager
Expand Down
3 changes: 2 additions & 1 deletion deployment/helm/memory-qos/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,9 @@ customize with their own values, along with the default values.
| `image.tag` | unstable | container image tag |
| `image.pullPolicy` | Always | image pull policy |
| `resources.cpu` | 10m | cpu resources for the Pod |
| `resources.memory` | 100Mi | memory qouta for the |
| `resources.memory` | 100Mi | memory qouta for the Pod |
| `nri.patchRuntimeConfig` | false | enable NRI in containerd or CRI-O |
| `nri.setPodPriorityClassNodeCritical` | false | enable [marking Pod as node critical](https://kubernetes.io/docs/tasks/administer-cluster/guaranteed-scheduling-critical-addon-pods/#marking-pod-as-critical) |
| `initImage.name` | [ghcr.io/containers/nri-plugins/config-manager](https://ghcr.io/containers/nri-plugins/config-manager) | init container image name |
| `initImage.tag` | unstable | init container image tag |
| `initImage.pullPolicy` | Always | init container image pull policy |
Expand Down
3 changes: 3 additions & 0 deletions deployment/helm/memory-qos/templates/daemonset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,9 @@ spec:
mountPath: /etc/nri/memory-qos
- name: nrisockets
mountPath: /var/run/nri
{{- if .Values.nri.setPodPriorityClassNodeCritical }}
priorityClassName: system-node-critical
{{- end }}
volumes:
- name: memory-qos-config-vol
configMap:
Expand Down
4 changes: 4 additions & 0 deletions deployment/helm/memory-qos/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@ resources:

nri:
patchRuntimeConfig: false
# NRI plugins should be considered as part of the container runtime.
# Therefore, adding the system-node-critical priority class to the DaemonSet,
# could mitigate potential risk in a running system under load.
setPodPriorityClassNodeCritical: false

initContainerImage:
name: ghcr.io/containers/nri-plugins/nri-config-manager
Expand Down
3 changes: 2 additions & 1 deletion deployment/helm/memtierd/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,9 +93,10 @@ customize with their own values, along with the default values.
| `image.tag` | unstable | container image tag |
| `image.pullPolicy` | Always | image pull policy |
| `resources.cpu` | 250m | cpu resources for the Pod |
| `resources.memory` | 100Mi | memory qouta for the |
| `resources.memory` | 100Mi | memory qouta for the Pod |
| `outputDir` | empty string | host directory for memtierd.output files |
| `nri.patchRuntimeConfig` | false | enable NRI in containerd or CRI-O |
| `nri.setPodPriorityClassNodeCritical` | false | enable [marking Pod as node critical](https://kubernetes.io/docs/tasks/administer-cluster/guaranteed-scheduling-critical-addon-pods/#marking-pod-as-critical) |
| `initImage.name` | [ghcr.io/containers/nri-plugins/config-manager](https://ghcr.io/containers/nri-plugins/config-manager) | init container image name |
| `initImage.tag` | unstable | init container image tag |
| `initImage.pullPolicy` | Always | init container image pull policy |
Expand Down
3 changes: 3 additions & 0 deletions deployment/helm/memtierd/templates/daemonset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,9 @@ spec:
- name: run-dir-vol
mountPath: /run-dir
{{- end }}
{{- if .Values.nri.setPodPriorityClassNodeCritical }}
priorityClassName: system-node-critical
{{- end }}
volumes:
- name: memtierd-config-vol
configMap:
Expand Down
4 changes: 4 additions & 0 deletions deployment/helm/memtierd/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@ outputDir: ""

nri:
patchRuntimeConfig: false
# NRI plugins should be considered as part of the container runtime.
# Therefore, adding the system-node-critical priority class to the DaemonSet,
# could mitigate potential risk in a running system under load.
setPodPriorityClassNodeCritical: false

initContainerImage:
name: ghcr.io/containers/nri-plugins/nri-config-manager
Expand Down
6 changes: 4 additions & 2 deletions deployment/helm/sgx-epc/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,9 +94,11 @@ customize with their own values, along with the default values.
| `image.tag` | unstable | container image tag |
| `image.pullPolicy` | Always | image pull policy |
| `resources.cpu` | 25m | cpu resources for the Pod |
| `resources.memory` | 100Mi | memory qouta for the |
| `resources.memory` | 100Mi | memory qouta for the Pod |
| `nri.patchRuntimeConfig` | false | enable NRI in containerd or CRI-O |
| `initImage.name` | [ghcr.io/containers/nri-plugins/config-manager](https://ghcr.io/containers/nri-plugins/config-manager) | init container image name |
| `nri.setPodPriorityClassNodeCritical` | false | enable [marking Pod as node critical](https://kubernetes.io/docs/tasks/administer-cluster/guaranteed-scheduling-critical-addon-pods/#marking-pod-as-critical) |
| `initImage.name` | [ghcr.io/containers/nri-plugins/config-manager](https://ghcr.io/containers/nri-plugins/config-manager) |
| init container image name |
| `initImage.tag` | unstable | init container image tag |
| `initImage.pullPolicy` | Always | init container image pull policy |
| `tolerations` | [] | specify taint toleration key, operator and effect |
Expand Down
3 changes: 3 additions & 0 deletions deployment/helm/sgx-epc/templates/daemonset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,9 @@ spec:
volumeMounts:
- name: nrisockets
mountPath: /var/run/nri
{{- if .Values.nri.setPodPriorityClassNodeCritical }}
priorityClassName: system-node-critical
{{- end }}
volumes:
- name: nrisockets
hostPath:
Expand Down
4 changes: 4 additions & 0 deletions deployment/helm/sgx-epc/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@ resources:

nri:
patchRuntimeConfig: false
# NRI plugins should be considered as part of the container runtime.
# Therefore, adding the system-node-critical priority class to the DaemonSet,
# could mitigate potential risk in a running system under load.
setPodPriorityClassNodeCritical: false

initContainerImage:
name: ghcr.io/containers/nri-plugins/nri-config-manager
Expand Down
1 change: 1 addition & 0 deletions deployment/helm/template/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ customize with their own values, along with the default values.
| `hostPort` | 8891 | metrics port to expose on the host |
| `config` | see [helm chart values](tree:/deployment/helm/template/values.yaml) for the default configuration | plugin configuration data |
| `nri.patchRuntimeConfig` | false | enable NRI in containerd or CRI-O |
| `nri.setPodPriorityClassNodeCritical` | false | enable [marking Pod as node critical](https://kubernetes.io/docs/tasks/administer-cluster/guaranteed-scheduling-critical-addon-pods/#marking-pod-as-critical) |
| `initImage.name` | [ghcr.io/containers/nri-plugins/config-manager](https://ghcr.io/containers/nri-plugins/config-manager) | init container image name |
| `initImage.tag` | unstable | init container image tag |
| `initImage.pullPolicy` | Always | init container image pull policy |
Expand Down
3 changes: 3 additions & 0 deletions deployment/helm/template/templates/daemonset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,9 @@ spec:
mountPath: /var/run/nri-resource-policy
- name: nrisockets
mountPath: /var/run/nri
{{- if .Values.nri.setPodPriorityClassNodeCritical }}
priorityClassName: system-node-critical
{{- end }}
volumes:
- name: resource-policydata
hostPath:
Expand Down
4 changes: 4 additions & 0 deletions deployment/helm/template/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,10 @@ resources:

nri:
patchRuntimeConfig: false
# NRI plugins should be considered as part of the container runtime.
# Therefore, adding the system-node-critical priority class to the DaemonSet,
# could mitigate potential risk in a running system under load.
setPodPriorityClassNodeCritical: false

initContainerImage:
name: ghcr.io/containers/nri-plugins/nri-config-manager
Expand Down
1 change: 1 addition & 0 deletions deployment/helm/topology-aware/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ customize with their own values, along with the default values.
| `hostPort` | 8891 | metrics port to expose on the host |
| `config` | see [helm chart values](tree:/deployment/helm/topology-aware/values.yaml) for the default configuration | plugin configuration data |
| `nri.patchRuntimeConfig` | false | enable NRI in containerd or CRI-O |
| `nri.setPodPriorityClassNodeCritical` | false | enable [marking Pod as node critical](https://kubernetes.io/docs/tasks/administer-cluster/guaranteed-scheduling-critical-addon-pods/#marking-pod-as-critical) |
| `initImage.name` | [ghcr.io/containers/nri-plugins/config-manager](https://ghcr.io/containers/nri-plugins/config-manager) | init container image name |
| `initImage.tag` | unstable | init container image tag |
| `initImage.pullPolicy` | Always | init container image pull policy |
Expand Down
3 changes: 3 additions & 0 deletions deployment/helm/topology-aware/templates/daemonset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,9 @@ spec:
mountPath: /var/run/nri-resource-policy
- name: nrisockets
mountPath: /var/run/nri
{{- if .Values.nri.setPodPriorityClassNodeCritical }}
priorityClassName: system-node-critical
{{- end }}
volumes:
- name: resource-policydata
hostPath:
Expand Down
5 changes: 4 additions & 1 deletion deployment/helm/topology-aware/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,10 @@ resources:

nri:
patchRuntimeConfig: false

# NRI plugins should be considered as part of the container runtime.
# Therefore, adding the system-node-critical priority class to the DaemonSet,
# could mitigate potential risk in a running system under load.
setPodPriorityClassNodeCritical: false

initContainerImage:
name: ghcr.io/containers/nri-plugins/nri-config-manager
Expand Down