apiv2 container create using specgen #5204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
approved
larsks
reviewed
Feb 13, 2020
baude
force-pushed
the
apiv2createlibpod
branch
from
0bd0265 to
e3d3c62
Compare
mheon
reviewed
Feb 13, 2020
mheon
reviewed
Feb 13, 2020
mheon
reviewed
Feb 13, 2020
mheon
reviewed
Feb 13, 2020
mheon
reviewed
Feb 13, 2020
mheon
reviewed
Feb 13, 2020
mheon
reviewed
Feb 13, 2020
pkg/specgen/create.go
Outdated
Member
There was a problem hiding this comment.
You know, I think useImageVolumes might be 100% unused...
Member
Author
There was a problem hiding this comment.
what do you want me to do; it is in the current code path.
mheon
reviewed
Feb 13, 2020
mheon
reviewed
Feb 13, 2020
pkg/specgen/create.go
Outdated
Member
There was a problem hiding this comment.
Shouldn't this also be only if len(s.Entrypoint) > 0?
Member
There was a problem hiding this comment.
Hmmm. We might want to pull from the image in that case.
mheon
reviewed
Feb 13, 2020
mheon
reviewed
Feb 13, 2020
mheon
reviewed
Feb 13, 2020
mheon
reviewed
Feb 13, 2020
mheon
reviewed
Feb 13, 2020
mheon
reviewed
Feb 13, 2020
mheon
reviewed
Feb 13, 2020
Member
|
I'll look into useImageVolumes on the Libpod side, and make a PR to tear it
out of it really is unused, we can merge that before or after this, doesn't
really matter
…On Fri, Feb 14, 2020, 09:17 Brent Baude ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In pkg/specgen/create.go
<#5204 (comment)>:
> + return nil, err
+ }
+
+ podmanPath, err := os.Executable()
+ if err != nil {
+ return nil, err
+ }
+ options = append(options, s.createExitCommandOption(rtc, podmanPath))
+ newImage, err := rt.ImageRuntime().NewFromLocal(s.Image)
+ if err != nil {
+ return nil, err
+ }
+
+ // TODO mheon wants to talk with Dan about this
+ useImageVolumes := s.ImageVolumeMode == "bind"
+ options = append(options, libpod.WithRootFSFromImage(newImage.ID(), s.Image, useImageVolumes))
what do you want me to do; it is in the current code path.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#5204>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB3AOCD2NF3KXBYUQU3M7SDRC2RXNANCNFSM4KU2VM3A>
.
|
baude
force-pushed
the
apiv2createlibpod
branch
from
e3d3c62 to
8e40a72
Compare
Collaborator
|
☔ The latest upstream changes (presumably #5203) made this pull request unmergeable. Please resolve the merge conflicts. |
openshift-ci-robot
added
the
needs-rebase
baude
force-pushed
the
apiv2createlibpod
branch
from
8e40a72 to
d859474
Compare
openshift-ci-robot
removed
the
needs-rebase
baude
force-pushed
the
apiv2createlibpod
branch
from
d859474 to
850c830
Compare
Member
rhatdan
reviewed
Feb 17, 2020
Collaborator
|
☔ The latest upstream changes (presumably #5158) made this pull request unmergeable. Please resolve the merge conflicts. |
openshift-ci-robot
added
the
needs-rebase
baude
force-pushed
the
apiv2createlibpod
branch
from
850c830 to
1d751c3
Compare
Collaborator
|
☔ The latest upstream changes (presumably #5225) made this pull request unmergeable. Please resolve the merge conflicts. |
baude
force-pushed
the
apiv2createlibpod
branch
from
1d751c3 to
293d063
Compare
mheon
reviewed
Feb 19, 2020
mheon
reviewed
Feb 19, 2020
mheon
reviewed
Feb 19, 2020
mheon
reviewed
Feb 19, 2020
mheon
reviewed
Feb 19, 2020
openshift-ci-robot
removed
the
needs-rebase
this uses the specgen structure to create containers rather than the outdated createconfig. right now, only the apiv2 create is wired up. eventually the cli will also have to be done. Signed-off-by: Brent Baude <[email protected]>
baude
force-pushed
the
apiv2createlibpod
branch
from
293d063 to
d65ff6b
Compare
Member
|
/lgtm |
edsantiago
added a commit
to edsantiago/libpod
that referenced
this pull request
Feb 20, 2020
PR containers#5204 added /libpod/containers/create but with the wrong swagger comment. Fix that. Also fix some other inconsistencies: missing 'libpod' prefix, missing 'Container' suffix, and change 'ContainerCreate' to 'CreateContainer'; all of these changes preserve consistency with both the invoked function as well as the overall naming conventions used in this module. Signed-off-by: Ed Santiago <[email protected]>
snj33v
pushed a commit
to snj33v/libpod
that referenced
this pull request
May 31, 2020
PR containers#5204 added /libpod/containers/create but with the wrong swagger comment. Fix that. Also fix some other inconsistencies: missing 'libpod' prefix, missing 'Container' suffix, and change 'ContainerCreate' to 'CreateContainer'; all of these changes preserve consistency with both the invoked function as well as the overall naming conventions used in this module. Signed-off-by: Ed Santiago <[email protected]>
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this uses the specgen structure to create containers rather than the outdated createconfig. right now, only the apiv2 create is wired up. eventually the cli will also have to be done.
Signed-off-by: Brent Baude [email protected]