APIv2 review corrections #3 #4965
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
approved
mheon
reviewed
Jan 24, 2020
mheon
reviewed
Jan 24, 2020
mheon
reviewed
Jan 24, 2020
mheon
reviewed
Jan 24, 2020
pkg/api/server/register_images.go
Outdated
Member
There was a problem hiding this comment.
Can't we just say "non-dangling images" instead? It seems much clearer
Member
Author
There was a problem hiding this comment.
thats what you agreed to earlier ...
baude
force-pushed
the
reviewcorrections3
branch
3 times, most recently
from
3fd43cd to
afec62c
Compare
jwhonce
suggested changes
Jan 24, 2020
pkg/api/handlers/libpod/images.go
Outdated
Member
There was a problem hiding this comment.
These json schemes should be schema.
baude
force-pushed
the
reviewcorrections3
branch
from
afec62c to
10f9b41
Compare
The third pass of corrections for the APIv2. Signed-off-by: Brent Baude <bbaude@redhat.com>
baude
force-pushed
the
reviewcorrections3
branch
from
10f9b41 to
5da70b0
Compare
Member
Author
|
review comments addressed, please merge |
Member
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The third pass of corrections for the APIv2.
Signed-off-by: Brent Baude bbaude@redhat.com