Skip to content

Conversation

@vrothberg
Copy link
Member

Signed-off-by: Valentin Rothberg [email protected]

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 9, 2019
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 9, 2019
vrothberg added a commit to vrothberg/cri-o that referenced this pull request Apr 9, 2019
PR: containers/podman#2875

Signed-off-by: Valentin Rothberg <[email protected]>
@vrothberg vrothberg force-pushed the image-commit branch 6 times, most recently from 312b9b3 to d9d46a8 Compare April 16, 2019 09:31
@rh-atomic-bot
Copy link
Collaborator

☔ The latest upstream changes (presumably #2931) made this pull request unmergeable. Please resolve the merge conflicts.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 23, 2019
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 23, 2019
@rh-atomic-bot
Copy link
Collaborator

☔ The latest upstream changes (presumably #3005) made this pull request unmergeable. Please resolve the merge conflicts.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 26, 2019
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 13, 2019
Signed-off-by: Valentin Rothberg <[email protected]>
@rh-atomic-bot
Copy link
Collaborator

☔ The latest upstream changes (presumably #3149) made this pull request unmergeable. Please resolve the merge conflicts.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 17, 2019
@openshift-ci-robot
Copy link
Collaborator

@vrothberg: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhatdan
Copy link
Member

rhatdan commented Jun 8, 2019

I think we have updated containers/image since this PR was opened. Closing.

@rhatdan rhatdan closed this Jun 8, 2019
@vrothberg
Copy link
Member Author

Reopening, since this is the PR for testing containers/image#611. containers/image#611 is a very invasive change, so we need to make sure that all CIs are happy with the changes.

@vrothberg vrothberg reopened this Jun 9, 2019
@openshift-ci-robot
Copy link
Collaborator

@vrothberg: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/validate af583d8 link /test validate
ci/prow/lint af583d8 link /test lint

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vrothberg
Copy link
Member Author

Closing as the c/image PR has stalled.

@vrothberg vrothberg closed this Jul 25, 2019
@vrothberg vrothberg deleted the image-commit branch July 25, 2019 09:42
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants