slirp4netns: use --disable-host-loopback #2644
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
approved
Closes: containers#2642 Signed-off-by: Giuseppe Scrivano <[email protected]>
giuseppe
force-pushed
the
slirp-disable-lo
branch
from
4e14ac6 to
473f28a
Compare
Member
|
LGTM assuming happy tests |
Member
|
/lgtm |
Member
Author
|
looks like there are two broken tests but still the openshift-robot merged :( |
Member
|
I don't know if I trust it anymore - it doesn't seem to work well for our multi-CI-system environment. We might have to start restricting /lgtm to having manually inspected all the tests and verified they are green. |
Member
Author
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2642
Signed-off-by: Giuseppe Scrivano [email protected]