refactor(auth): remove unused tool-scoped authorization middleware#633
Merged
matzew merged 1 commit intocontainers:mainfrom Jan 12, 2026
Merged
Conversation
The toolScopedAuthorizationMiddleware was conceived for tool authorization but the feature was dropped in favor of implementing this in an MCP gateway. This removes: - The middleware function and its registration - TokenScopesContextKey constant and ContextKey type - Scopes propagation code in authorization middleware Signed-off-by: Marc Nuri <marc@marcnuri.com>
77a002b to
3025ee7
Compare
manusa
added a commit
to marcnuri-forks/kubernetes-mcp-server
that referenced
this pull request
Jan 28, 2026
The toolScopedAuthorizationMiddleware was conceived for tool authorization but the feature was dropped in favor of implementing this in an MCP gateway. This removes: - The middleware function and its registration - TokenScopesContextKey constant and tokenScopesContextKeyType type - Unused imports (fmt, slices) in middleware.go This change was accidentally reverted in PR containers#590 and is now being re-applied (originally from PR containers#633). Signed-off-by: Marc Nuri <marc@marcnuri.com>
Cali0707
pushed a commit
that referenced
this pull request
Jan 28, 2026
) The toolScopedAuthorizationMiddleware was conceived for tool authorization but the feature was dropped in favor of implementing this in an MCP gateway. This removes: - The middleware function and its registration - TokenScopesContextKey constant and tokenScopesContextKeyType type - Unused imports (fmt, slices) in middleware.go This change was accidentally reverted in PR #590 and is now being re-applied (originally from PR #633). Signed-off-by: Marc Nuri <marc@marcnuri.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The toolScopedAuthorizationMiddleware was conceived for tool authorization but the feature was dropped in favor of implementing this in an MCP gateway. This removes:
Relates to: