chore(kubevirt): add eval tasks for VM creation and lifecycle#626
chore(kubevirt): add eval tasks for VM creation and lifecycle#626manusa merged 2 commits intocontainers:mainfrom
Conversation
|
/run-gevals |
/hold Apologies I should make it clear this isn't going to work on the existing generic k8s gevals test runner, assuming this is running everything under |
6827983 to
f7d7198
Compare
f7d7198 to
718418b
Compare
codingben
left a comment
There was a problem hiding this comment.
Just started trying it, until then a partial review
| @echo "Or run with MCP inspector:" | ||
| @echo " npx @modelcontextprotocol/inspector@latest \$$(pwd)/$(BINARY_NAME) --config _output/config.toml" | ||
|
|
||
| .PHONY: local-env-setup-kubevirt |
There was a problem hiding this comment.
based on prior internal discussions, we might want to remove the local-env-setup and others, and leave the more local granular tasks (kind, keycloak, kiali, and kubevirt)
cc @matzew
There was a problem hiding this comment.
@manusa I don't mind either way but maybe for now that's something we could handle in a follow up that also removes these local-env-setup targets?
718418b to
d1d3072
Compare
|
@codingben @ksimon1 would you mind taking another look at this? |
Add comprehensive KubeVirt support to enable local testing of VM management tools with a complete Kind + KubeVirt setup. New Makefile Targets: - local-env-setup-kubevirt: Complete environment setup including KubeVirt - kubevirt-install: Install KubeVirt operator and CDI - kubevirt-uninstall: Remove KubeVirt and CDI from cluster - kubevirt-status: Display KubeVirt, CDI, and VM status KubeVirt Installation (build/kubevirt.mk): - Installs KubeVirt v1.7.0 operator and custom resource - Installs CDI (Containerized Data Importer) v1.64.0 for disk management - Waits for components to be ready before proceeding - Provides status checking for all KubeVirt resources The local-env-setup-kubevirt target orchestrates a complete setup: 1. Creates Kind cluster with ingress and cert-manager 2. Installs KubeVirt and CDI 3. Builds the MCP server binary This enables developers to test VM lifecycle management tools (start, stop, restart, create) in a local Kubernetes environment. Assisted-By: Claude <noreply@anthropic.com> Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
d1d3072 to
782c6b6
Compare
|
Thanks @ksimon1 I've addressed your comments. |
782c6b6 to
16e0dad
Compare
Add evaluation tasks for testing KubeVirt virtual machine operations through the kubernetes-mcp-server's vm_create and vm_lifecycle tools. Tasks added: - create-vm-basic: Create a basic Fedora VM - create-vm-ubuntu: Create an Ubuntu VM - create-vm-with-instancetype: Create VM with specific instance type - create-vm-with-size: Create VM with size hint - delete-vm: Delete a running VM - pause-vm: Pause and unpause a VM - update-vm-resources: Modify CPU and memory of existing VM Infrastructure: - Shared verification helpers for VM state validation - Test functions for instancetype, resources, and networking - Support for both container disk and DataSource-based VMs These tasks validate that AI agents can correctly use the KubeVirt MCP tools to manage virtual machine lifecycles, including proper use of modern runStrategy field instead of deprecated 'running' field. Assisted-By: Claude <noreply@anthropic.com> Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
16e0dad to
43600cf
Compare
|
/lgtm |
Add evaluation tasks for testing KubeVirt virtual machine operations through the kubernetes-mcp-server's vm_create and vm_lifecycle tools.
Tasks added:
Infrastructure:
These tasks validate that AI agents can correctly use the KubeVirt MCP tools to manage virtual machine lifecycles, including proper use of modern runStrategy field instead of deprecated 'running' field.