Merged
Conversation
Signed-off-by: josunect <jcordoba@redhat.com>
Signed-off-by: josunect <jcordoba@redhat.com>
Signed-off-by: josunect <jcordoba@redhat.com>
Signed-off-by: josunect <jcordoba@redhat.com>
Signed-off-by: josunect <jcordoba@redhat.com>
Signed-off-by: josunect <jcordoba@redhat.com>
Signed-off-by: josunect <jcordoba@redhat.com>
Signed-off-by: josunect <jcordoba@redhat.com>
Contributor
|
cc @Cali0707 Can we merge this test validation? |
manusa
approved these changes
Jan 12, 2026
Member
manusa
left a comment
There was a problem hiding this comment.
This seems reasonable. However, I fail to see why the backend tests are maintained here if they are executed from a different repo.
Contributor
Author
That's because they are testing the endpoints implemented by the other repo (Maintained by the same team). So, if any endpoint is modified, the tests will fail, and the way to fix it would be:
|
Cali0707
reviewed
Jan 16, 2026
| @@ -0,0 +1,683 @@ | |||
| //go:build contract | |||
Collaborator
There was a problem hiding this comment.
nit: can we make this something like kiali-contract ? Just to be a bit more explicit about which contract we are testing
Signed-off-by: josunect <jcordoba@redhat.com>
Signed-off-by: josunect <jcordoba@redhat.com>
Cali0707
approved these changes
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated Consistency Tests: Verify MCP Tool Definitions against Kiali API Routes
How do we know that APIs used by the consumer (kiali mcp) still exist and return what it expects?
Contract tests keep coupling low because they only describe:
TODO:
endpoints.goare tested