test: replace custom WaitForCondition with testify assertions #550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nader-ziada
reviewed
Dec 4, 2025
| defer watcher.mu.Unlock() | ||
| return len(watcher.lastKnownState.apiGroups) > 0 | ||
| }), "timeout waiting for watcher to capture initial state") | ||
| }, watcherStateTimeout, eventuallyTick, "timeout waiting for watcher to capture initial state") |
Collaborator
There was a problem hiding this comment.
what is the timeout value based on? its had multiple different values
Member
Author
There was a problem hiding this comment.
I think I messed with those while trying to fix the windows flakyness, hence the multiple changes.
At the moment it's 100ms which is double than the poll interval set in the test (50ms)
Collaborator
There was a problem hiding this comment.
so you want to keep them at different values for each test?
Member
Author
There was a problem hiding this comment.
Sorry, I misunderstood your question. I see what you mean now, let me change.
Member
Author
There was a problem hiding this comment.
Changed, let me know if the new values make sense.
Signed-off-by: Marc Nuri <[email protected]>
Collaborator
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.