feat(kiali): add aggregated health summary to mesh graph tool#506
feat(kiali): add aggregated health summary to mesh graph tool#506manusa merged 5 commits intocontainers:mainfrom
Conversation
hhovsepy
force-pushed
the
kiali_mesh_graph_summary_health
branch
from
38169d0 to
ad0f311
Compare
pkg/kiali/get_mesh_graph.go
Outdated
| Outbound map[string]map[string]float64 `json:"outbound"` | ||
| HealthAnnotations map[string]string `json:"healthAnnotations"` | ||
| } | ||
|
|
There was a problem hiding this comment.
I would move this to a new file called types.go to keep clean this one
pkg/kiali/get_mesh_graph.go
Outdated
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Can we move this logic into a helper_calculation file or something similar? The idea is to make it easier to test and keep the call file clean.
On another note, I’m wondering whether it makes sense to keep health in the struct when MeshHealthSummary is already using it for computation. Is there any additional information in health that isn’t already included in MeshHealthSummary?
There was a problem hiding this comment.
good point, I think the Health in response is not needed anymore, if more information would be needed, we can add into the MeshHealthSummary
|
Thanks @aljesusg , all comments approached. |
hhovsepy
force-pushed
the
kiali_mesh_graph_summary_health
branch
from
88bbb78 to
7455ae9
Compare
aljesusg
left a comment
aljesusg
left a comment
There was a problem hiding this comment.
Everything else looks good; only this change is needed.
Signed-off-by: Hayk Hovsepyan <hhovsepy@redhat.com>
Signed-off-by: Hayk Hovsepyan <hhovsepy@redhat.com>
Signed-off-by: Hayk Hovsepyan <hhovsepy@redhat.com>
Signed-off-by: Hayk Hovsepyan <hhovsepy@redhat.com>
Co-authored-by: Alberto Gutierrez <aljesusg@gmail.com> Signed-off-by: Hayk Hovsepyan <hhovsepy@redhat.com>
hhovsepy
force-pushed
the
kiali_mesh_graph_summary_health
branch
from
0a0f3c9 to
e03219c
Compare
manusa
changed the title
| "rateInterval": { | ||
| Type: "string", | ||
| Description: "Rate interval for fetching (e.g., '10m', '5m', '1h'). Default: '60s'", | ||
| Description: "Rate interval for fetching (e.g., '10m', '5m', '1h'). Default: '10m'", |
There was a problem hiding this comment.
Note that you can include a Default: api.ToRawMessage(kialiclient.DefaultRateInterval)
to improve the toolset documentation
There was a problem hiding this comment.
Great I am going to move all defaults and do it thabks !
| "rateInterval": { | ||
| Type: "string", | ||
| Description: "Rate interval for metrics (e.g., '1m', '5m'). Optional, defaults to '1m'", | ||
| Description: "Rate interval for metrics (e.g., '1m', '5m'). Optional, defaults to '10m'", |
There was a problem hiding this comment.
3 participants
For 'kiali_get_mesh_graph' tool, added summary health call as well.
Original PR: #479