feat: add AccessControl rest client#473
Closed
Cali0707 wants to merge 2 commits intocontainers:mainfrom
Closed
Conversation
Signed-off-by: Calum Murray <cmurray@redhat.com>
Signed-off-by: Calum Murray <cmurray@redhat.com>
Collaborator
Author
|
@manusa not totally sure if we want this or not, just trying to prototype some ways to make it easier for toolset authors to do what they want while enforcing the access control. Lmk what you think! |
Member
|
This is exactly the approach I wanted to follow: Move it up the stack as much as possible so that we don't need to check for access at the specific clients. What I'm not sure is about the side-effects of this approach, neither if there are edge cases that need further consideratio. Let me work on the base you created here and see if we can actually free ourselves from the other client implementations and fixes. |
This was referenced Nov 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To make it easier for people adding toolsets to complete arbitrary actions against arbitrary resources while maintaining the access control, this creates a
rest.Interfacethat is configured with a roundtripper that will ensure that only requests against GVRs that are allowed can be made.