test(mcp): add tests for WatchKubeConfig tools reload#449
test(mcp): add tests for WatchKubeConfig tools reload#449matzew merged 1 commit intocontainers:mainfrom
Conversation
manusa
force-pushed
the
test/tools-reload
branch
from
c912484 to
e2feff5
Compare
Verifies that tools are added and **removed** when kubeconfig file changes. Signed-off-by: Marc Nuri <marc@marcnuri.com>
manusa
force-pushed
the
test/tools-reload
branch
from
e2feff5 to
8b14937
Compare
|
|
||
| s.Run("OpenShift tool is removed after kubeconfig change", func() { | ||
| // Reload Config without OpenShift | ||
| s.mockServer.ResetHandlers() |
There was a problem hiding this comment.
It took me a bit, to see that it actually "reset" the handlers (while the other one accepts one handler).
I guess no major issue
There was a problem hiding this comment.
I can try to make it clearer.
This was the easiest path I found to test the functionality.
I will probably improve the test with a custom provider to verify other behaviors such as the Provider close if exists:
kubernetes-mcp-server/pkg/mcp/mcp.go
Lines 107 to 110 in 6342379
and so on.
Bu It don't want to spend too much time on this at the moment since it's blocking #385
| } | ||
|
|
||
| func (m *MockServer) ResetHandlers() { | ||
| m.restHandlers = make([]http.HandlerFunc, 0) |
There was a problem hiding this comment.
there is similar code above when creating the server
is this worth to call out as an issue on the repo, or was already a similar issue? |
|
LGTM |
Once I implement the workaround here I'll open a PR upstream so it's clear what's the problem. I was the one who actually implemented SetTools in the mark3labs repo mark3labs/mcp-go#24 in the first place :) |
2 participants
Ensures #385 / #219 preserves current behavior.
Verifies that tools are added and removed when kubeconfig file changes.
Go SDK lacks a SetTools method, AddTool only upserts tools. This test verifies that internally we handle the case that no-longer applicable tools are removed from the list of tools.