fix(toolsets): remove "redundant" annotations that have defaults#441
Merged
Cali0707 merged 1 commit intocontainers:mainfrom Nov 5, 2025
Merged
fix(toolsets): remove "redundant" annotations that have defaults#441Cali0707 merged 1 commit intocontainers:mainfrom
Cali0707 merged 1 commit intocontainers:mainfrom
Conversation
The removed annotations have default values and are not needed. I personally prefer to keep them because it makes it easier for reviewers to understand the tool behaviors. However, this is problematic with go-sdk since these values aren't marshalled/serialized (omitempty). Signed-off-by: Marc Nuri <marc@marcnuri.com>
Cali0707
reviewed
Nov 5, 2025
| ReadOnlyHint: ptr.To(false), | ||
| DestructiveHint: ptr.To(false), | ||
| IdempotentHint: ptr.To(false), // TODO: consider replacing implementation with equivalent to: helm upgrade --install | ||
| IdempotentHint: nil, // TODO: consider replacing implementation with equivalent to: helm upgrade --install |
Collaborator
There was a problem hiding this comment.
Is there a reason why this is nil here and just removed elsewhere?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will facilitate #385
The removed annotations have default values and are not needed. I personally prefer to keep them because it makes it easier for reviewers to understand the tool behaviors.
However, this is problematic with go-sdk since these values aren't marshalled/serialized (omitempty).